feat(core): add partial support for ES6 computed property names #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computed property names were introduced in ES6. "Partial" in a sense that few computed property name usage are not supported. As well for when using with ES5 functions, not arrow functions. Closes #289
…d match all the away
Since we are using a constant regex that has the `g` flag in iterator we should make sure that it is in the initial state. See http://speakingjs.com/es5/ch19.html
|
Kudos, SonarCloud Quality Gate passed!
|
micalevisk
commented
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #289
"Partial" in a sense that few computed property name usage are not supported (see them in
get-member-path.spec.tsfile)I'm not sure if I need to update the minor version on
package.jsonin this PR. Let me know if I should.