Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dependencies] Add support for React 18 #845

Closed
akdetrick opened this issue Nov 10, 2022 · 2 comments · Fixed by #928
Closed

[dependencies] Add support for React 18 #845

akdetrick opened this issue Nov 10, 2022 · 2 comments · Fixed by #928
Labels
Platform fixes ticket visibility in project planning released
Milestone
2023.05-1

Comments

@akdetrick
Copy link
Collaborator

  • update peer dependencies to include support for React v18
  • add testing tool that can run tests against multiple versions of react
  • add workflow to run react versions test on PRs
@akdetrick akdetrick added the Platform fixes ticket visibility in project planning label Nov 10, 2022
@akdetrick
Copy link
Collaborator Author

Looks like a number of packages we use don't support React 18 yet:

We may be able to get around this by using the legacy-peer-deps or upgrading the dependency to latest.

@akdetrick akdetrick mentioned this issue May 2, 2023
Merged
@akdetrick akdetrick added this to the 2023.05-1 milestone May 2, 2023
@narmirobot
Copy link

🎉 This issue has been resolved in version 2.45.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Platform fixes ticket visibility in project planning released
Projects
None yet
Milestone
2023.05-1
Development

Successfully merging a pull request may close this issue.

feat: Support React 18 consumers narmi/design_system
2 participants
@akdetrick @narmirobot