-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npe2api shouldn't list plugins that have been taken down from PyPI/conda-forge #31
Comments
@Czaki that's the new package? The old package is not available on PyPI anymore? |
The old package name is mmv_hitl4trk |
old name is listed in deleted section of classifiers. However, it is listed in an endpoint that is used by the plugin manager But without any available version (also for correct name). So it suggests that error is in https://github.com/napari/npe2api/blob/main/scripts/reindex.py or in a plugin manager code. Maybe @tlambert03 remember what is expected behavior. |
didn't this come up before @DragaDoncila? yes, as @Czaki said, the source of truth for plugin status is Originally, I intended for there to be a two-step fetch process from npe2api (one to classifiers to get the active/withdrawn/deleted status, and a second one to fetch details) ... but I think there was a push to combine all of the info that napari wanted into a single endpoint (can't remember now if that was "summary" or "extended_summary" and I can't remember what the difference between those is). So i'm no longer sure about where the data is getting aggregated |
Currently, napari iterates over entries of |
ok, then one possible solution here is for the plugin manager dialog to skip packages for which both |
Ok. So it looks like we have a clear view of the situation and could make a decision now. Thanks @tlambert03 for the information. |
@jni do you have a preference for whether we update We should at a minimum update |
I don't have a strong preference but I don't see a reason why packages that aren't in either package repository should appear in the extended_summary... (If we ever e.g. allow direct installs from GitHub, then we can treat that as another package repository and apply the same logic.) |
OK so sounds like action item is to update the |
Based on this Zulip thread, I looked around for mmv_hitl4trk in the repo and found it listed in index.json:
npe2api/public/index.json
Lines 53 to 54 in d477c45
It seems to me that plugins that have been removed from PyPI and conda should not appear in npe2api, but I'm not 100% sure whether there are some npe2api use cases that require historical data.
CC @lennartkowitz @DragaDoncila @jaimergp
The text was updated successfully, but these errors were encountered: