Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined reference Colormap #39

Open
MosGeo opened this issue Oct 30, 2024 · 2 comments
Open

Undefined reference Colormap #39

MosGeo opened this issue Oct 30, 2024 · 2 comments

Comments

@MosGeo
Copy link

MosGeo commented Oct 30, 2024

I am not using this function but I am guessing that this line would produce an error if you ever reach it. Colormap (with capital C) is not defined anywhere else nor imported.

https://github.com/napari/napari-tiff/blob/8c704181275bc21e2ba220e4bd1bf44a97b204c4/napari_tiff/napari_tiff_metadata.py#L221C25-L221C33

@DragaDoncila
Copy link

Thanks for opening this @MosGeo! @Czaki @jni not particularly high priority but probably something we should look at?

@Czaki
Copy link
Contributor

Czaki commented Nov 6, 2024

I think that it is artfact left by @GenevieveBuckley in #31 that I missed in review.

I feel that code [(c.T / 255.0) for c in ijmeta["LUTs"]] should work, but do not have time yet to test it yet.

Currently it broke reading imagej tiff so I think it should be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants