Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin manager does not respect the visibility field in the manifest #25

Open
DragaDoncila opened this issue Sep 19, 2023 · 4 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@DragaDoncila
Copy link
Contributor

The current version of npe2 supports setting the visibility field in the plugin manifest to hidden if the plugin developer wants to keep the Framework:: napari classifier but not be discoverable on the napari hub and in the plugin manager. The napari hub is being updated to respect this field as we speak, but we should also update the plugin manager to respect this field and not display plugins with visibility: hidden in search results.

@goanpeca goanpeca self-assigned this Nov 14, 2023
@goanpeca
Copy link
Contributor

Thanks for the heads up @DragaDoncila, will work on a fix :)

@Czaki
Copy link
Contributor

Czaki commented Nov 14, 2023

I think that we should update the server that gathers this information for us. So I think that this issue should be moved to https://github.com/napari/npe2api

@goanpeca
Copy link
Contributor

That is a good suggestion indeed. You suggest that the info we query over at npe2api already only includes visible plugins? or that it contains that info over there and we still filter them directly on the plugin manager?

@Czaki
Copy link
Contributor

Czaki commented Nov 15, 2023

I suggest that npe2api should not serve information about hidden plugins.

@goanpeca goanpeca added the enhancement New feature or request label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants