Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: give embedded videos responsive size #205

Open
GenevieveBuckley opened this issue Feb 2, 2024 · 1 comment
Open

Docs: give embedded videos responsive size #205

GenevieveBuckley opened this issue Feb 2, 2024 · 1 comment

Comments

@GenevieveBuckley
Copy link
Contributor

This nice to have to-do item came up during development of #200

#200 (comment)

Responsive (or percentage based) sizing of embedded videos. This currently isn't supported by the sphinx video plugin, so we'd have to either modify that or write our own HTML template string. (#200 (comment))

#200 (comment)

I don't like this part.
Currently it sets the width of the embedded video to 500 pixels. I'd prefer it was a percentage of the page width instead (i.e. more responsive to different screen sizes). I don't think you can do that easily with sphinxcontrib-video as it currently exists, so maybe we should replace this dependency with a template docstring of the HTML we need to embed in the RST document, so we can have more control over the output result.
Docs: https://github.com/sphinx-contrib/video

@psobolewskiPhD
Copy link
Member

There is an upstream PR for this: sphinx-contrib/video#26
but alas it might be withering on the vine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants