Skip to content
This repository has been archived by the owner on Sep 17, 2019. It is now read-only.

String types in mock driver / unit tests. #220

Open
bewing opened this issue Mar 14, 2017 · 1 comment
Open

String types in mock driver / unit tests. #220

bewing opened this issue Mar 14, 2017 · 1 comment
Assignees
Milestone

Comments

@bewing
Copy link
Member

bewing commented Mar 14, 2017

I noticed today when comparing output from a real call to the EOSDriver for a new method I was writing to output from the mock driver in napalm base, that the data returned by the mock driver may not be type unicode, when the data returned by the real driver is.

It has been posited in slack that this may be due to how the strings are read from disk by the mock driver, versus returned from other underlying libraries in the real drivers.

May wish to investigate changing how we read data for test cases in order to more accurately write unit tests, and avoid additional calls to py23_compat.text_type.

Test case and additional discussion needed.

@dbarrosop
Copy link
Member

I remember you already posted a suggested solution on slack, is this something you can PR?

@mirceaulinic mirceaulinic added this to the DISCUSSION milestone Mar 17, 2017
@bewing bewing self-assigned this Aug 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants