-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Remove cropSize prop or allow null Override #194
Comments
Also, forgot to mention that I'm using version
|
|
hmm is there any willingness to support an override/escape hatch of some sort? My application needs to support user generated content, including brand logos. And, as you can see from the screen shoot, that is exceedingly hard/borderline impossible with this library as currently configured. I would think others might have similar needs. Also, I'm not saying Thanks for the timely response btw! |
There is not enough time and sufficient reason to make this modification. |
The
cropSize
prop can become very problematic for images with certain dimensions - equidistant height/width works well, but others can be problematic. The react-easy-crop documentation oncropSize
states (in bold text): "You should probably not use this option and should rely on aspect instead. See ValentinH#186". For example, the cropper overlay for some portrait images is zoomed in so far that this great library is essentially unusable 🙁. What are your thoughts on moving the spreadcropperProps
to the last position rather than the first - thereby allowing overrides? Seems like a very quick fix. I can raise a quick PR if so.The text was updated successfully, but these errors were encountered: