Hardcoded paths (noise + excised tim)

[kmjc]

There are a few places where the directory structure and naming convention for the noise chains are hardcoded. There are a few separate expectations for what the path is and the files are called around the place, these are the ones I found.

in noise_utils.add_noise_to_model

pint_pal/src/pint_pal/noise_utils.py

Lines 277 to 284 in 5059239

	if not using_wideband:
	chaindir = os.path.join(base_dir,f'{model.PSR.value}_nb/')
	if compare_dir is not None:
	chaindir_compare = os.path.join(compare_dir,f'{model.PSR.value}_nb/')
	else:
	chaindir = os.path.join(base_dir,f'{model.PSR.value}_wb/')
	if compare_dir is not None:
	chaindir_compare = os.path.join(compare_dir,f'{model.PSR.value}_wb/')

pint_pal/src/pint_pal/noise_utils.py

Line 291 in 5059239

chainfile = chaindir + 'chain_1.txt'

in noise_utils.analyze_noise

pint_pal/src/pint_pal/noise_utils.py

Line 53 in 5059239

chainfile = chaindir + 'chain_1.txt'

pint_pal/src/pint_pal/noise_utils.py

Line 56 in 5059239

pars = np.loadtxt(chaindir + 'pars.txt', dtype = str)

pint_pal/src/pint_pal/noise_utils.py

Line 62 in 5059239

chainfile_compare = chaindir_compare + 'chain_1.txt'

pint_pal/src/pint_pal/noise_utils.py

Line 65 in 5059239

pars_compare = np.loadtxt(chaindir_compare + 'pars.txt', dtype = str)

pint_pal/src/pint_pal/noise_utils.py

Lines 108 to 111 in 5059239

	if '_wb' in chaindir:
	figbase = f"./{psr_name}_noise_posterior_wb"
	elif '_nb' in chaindir:
	figbase = f"./{psr_name}_noise_posterior_nb"

pint_pal/src/pint_pal/noise_utils.py

Line 133 in 5059239

if '_wb' in chaindir:

in utils.check_recentness_noise

pint_pal/src/pint_pal/utils.py

Lines 1235 to 1240 in 5059239

	noise_runs = [os.path.dirname(os.path.dirname(os.path.abspath(p)))
	for p in sorted(glob.glob(os.path.join(d,
	"..",
	"*.Noise.*",
	tc.get_source()+"_"+tc.get_toa_type().lower(),
	"chain*.txt")))]

Also the path to the excised TOAs is hardcoded in
utils.check_recentness_excision

pint_pal/src/pint_pal/utils.py

Lines 1270 to 1275 in 5059239

	excision_dirs = [os.path.dirname(os.path.dirname(os.path.abspath(p)))
	for p in sorted(glob.glob(os.path.join(d,
	"..", "..",
	"*.Outlier.*",
	tc.get_source()+"."+tc.get_toa_type().lower(),
	"*_excise.tim")))]

[rossjjennings]

Some of these, such as the use of chain_1.txt and pars.txt, are likely to be unproblematic, since the filenames are relatively standardized at the enterprise level. Others may cause problems, but it's likely we'll be changing the way we approach the noise analysis for NG20 anyway. We should revisit this once we have a better idea of how that will work.