Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons have shrunk on iOS 17 / Xcode 15 #60

Open
branaust opened this issue Sep 26, 2023 · 5 comments
Open

Icons have shrunk on iOS 17 / Xcode 15 #60

branaust opened this issue Sep 26, 2023 · 5 comments

Comments

@branaust
Copy link

Icons were working perfectly prior to upgrading to Xcode 15 and iOS 17. Below is a before and after of what our icons looked like:

BEFORE AFTER
266070634-a95785a1-1369-40db-abeb-adae860ee528.mov
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-09-26.at.08.25.01.mp4

implementation:

import { Icon } from '@ntwrk1/design-system';
import React from 'react';
import { Pressable, StyleSheet, Text } from 'react-native';

import { PrimaryColorPalette } from 'assets/colors';
import * as DropdownMenu from 'zeego/dropdown-menu';

export default function CompletedShowMenu({
  onDelete,
}: {
  onDelete: () => void;
}) {
  return (
    <DropdownMenu.Root>
      <DropdownMenu.Trigger action="press">
        <Pressable style={styles.triggerButton}>
          <Icon color={PrimaryColorPalette.MAIN_1} variant="MoreVertical" />
        </Pressable>
      </DropdownMenu.Trigger>

      <DropdownMenu.Content>
        <DropdownMenu.Item
          destructive
          key="remove"
          onSelect={onDelete}
          textValue="Remove"
        >
          <DropdownMenu.ItemTitle>
            <Text>Remove</Text>
          </DropdownMenu.ItemTitle>
          <DropdownMenu.ItemIcon
            ios={{
              name: 'trash',
              pointSize: 5,
              weight: 'semibold',
              scale: 'default',
            }}
          />
        </DropdownMenu.Item>
      </DropdownMenu.Content>
    </DropdownMenu.Root>
  );
}

const styles = StyleSheet.create({
  triggerButton: {
    height: 28,
    width: 28,
    justifyContent: 'center',
    alignItems: 'center',
    borderRadius: 50,
    borderColor: PrimaryColorPalette.MAIN_5,
    borderWidth: 1,
    transform: [{ rotate: '90deg' }],
  },
});

Xcode version 15.0
Simulator: iPhone 15 Pro

@nandorojo
Copy link
Owner

that’s not good. can you open an issue on the upstream ios library?

@nandorojo
Copy link
Owner

We are investigating this issue over the next few days.

@nandorojo
Copy link
Owner

This hasn't happened on our app for iOS 17, but I'm also on an iPhone 13 so that may be why.

@fobos531
Copy link
Contributor

Cannot reproduce on iPhone 14 Pro 17.0.3 - real device
Also not seeing it on Simulator - iPhone 14 Pro 17.0

@nandorojo
Copy link
Owner

Same, all of this works for me. Could you provide a reproduction? Going to close otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants