Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: use black, typing, PEP 8 #58

Open
technillogue opened this issue May 16, 2021 · 1 comment
Open

Proposal: use black, typing, PEP 8 #58

technillogue opened this issue May 16, 2021 · 1 comment

Comments

@technillogue
Copy link

PEP 8

Function names should be lowercase, with words separated by underscores as necessary to improve readability.
Variable names follow the same convention as function names.
mixedCase is allowed only in contexts where that's already the prevailing style (e.g. threading.py), to retain backwards compatibility.

This is the stuff I already partially have, would prefer for my fork/usage of splitwise, am happy to do but would otherwise keep in my fork, but maybe these would be welcome upstream?

@namaggarwal
Copy link
Owner

The problem with this is that it would be breaking changes. We can maintain function aliases and I would welcome that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants