Add grant option to mysqluser #319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. Let me take some time to check your change 🙏 |
nakamasato
reviewed
Apr 23, 2024
|
|
||
| func (r *MySQLUserReconciler) updateGrants(ctx context.Context, mysqlClient *sql.DB, mysqlUserName string, mysqlUserHost string, grants []mysqlv1alpha1.Grant) error { | ||
| log := log.FromContext(ctx) | ||
| _, err := mysqlClient.ExecContext(ctx, fmt.Sprintf("REVOKE ALL PRIVILEGES, GRANT OPTION FROM '%s'@'%s';", mysqlUserName, mysqlUserHost)) |
There was a problem hiding this comment.
I think if revoking all privileges in every reconciliation loop will make the the user unstable. So I'd like to consider other way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allow to define grant permissions to mysqluser.
Example:
apiVersion: mysql.nakamasato.com/v1alpha1
kind: MySQLUser
metadata:
name: sample-user
spec:
mysqlName: mysql-sample
host: '%'
grants:
- privileges: "ALL"
on: "mysql-sample-db1."
- privileges: "SELECT, INSERT, UPDATE"
on: "mysql-sample-db2."