Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require-closing-tags is not supported by antsamy.xsd #147

Closed
SushantC12 opened this issue Mar 3, 2022 · 5 comments
Closed

require-closing-tags is not supported by antsamy.xsd #147

SushantC12 opened this issue Mar 3, 2022 · 5 comments
Assignees

Comments

@SushantC12
Copy link

Please add "require-closing-tags" in antisamy.xsd file. XSD file treats it as child element and doesn't allow custom tag.

@davewichers
Copy link
Collaborator

@spassarop - What do you think?

@spassarop
Copy link
Collaborator

Its pertinent. require-closing-tags is not present in any example policy file right now and that's probably why we missed it.
Nowadays it is only used when printing closing tags on SAX scanner output to end it like <tag/> or <tag></tag> if it is empty and allowed. I'll add it as optional on the default schema.

@spassarop
Copy link
Collaborator

A PR was made with this along with some tests. It is now included in default schema file and it should be positioned at the end if present.

@davewichers
Copy link
Collaborator

@SushantC12 - This requested change has been implemented in the main branch and will go out with the 1.7.0 release. If you want to pull this directly, and test it yourself, please do.

@davewichers
Copy link
Collaborator

Fix included in v1.6.6 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants