Garbage characters when using tracing

[mamcx]

The tracy client show garbage characters in the output.

When I instrument code like

    #[tracing::instrument(skip(self, tx))]
    pub fn iter<'a>(&'a self, tx: &'a MutTxId, table_id: u32) -> Result<Iter<'a>, DBError> {

the table_id: u32 parameter is joined as zone:

iter{�[3mtable_id�[0m�[2m=�[0m1}

I expect it to be

iter (table_id:1)

or similar.

[Ralith]

Those look like ANSI escape codes. Perhaps something's trying to pretty-print that information for display in a terminal?

[mamcx]

Yes, they are. But how disable them for tracy?

We have the config here.

But we don't want to disable it globally:

    let fmt_layer = tracing_subscriber::fmt::Layer::default()
        .with_writer(write_to)
        .event_format(format)
        .with_ansi(false); <-- Need only for tracy

    let env_filter_layer = parse_from_file(&conf_file);

    let tracy_layer = if std::env::var("SPACETIMEDB_TRACY").is_ok() {
        Some(tracing_tracy::TracyLayer::new())
    } else {
        None
    };

    let subscriber = tracing_subscriber::Registry::default()
        .with(fmt_layer)
        .with(tracy_layer)
        .with(flame_layer);

[mamcx]

Oh, just reordering the layers works:

    let subscriber = tracing_subscriber::Registry::default()
        .with(tracy_layer)
        .with(fmt_layer)
        .with(flame_layer);

[nagisa]

Does it truly? I would expect that doing so should change the output of the stdout logs? The truly correct thing to do would be to provide a different type (even if just a newtype) for formatter. That way tracing-tracy will not attempt to re-use a formatted event/span representation from the other layer(s).