Adds support for specifying the Platform Toolset to PCbuild/build.bat #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-slashes as this can interfere mingw/msys despite them cmd being used as the shell (and they're more portable).
…more straight-forward for one to specify the platform toolset directlty from their shell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new parameter to
PCbuild/build.batwhich exposes setting the Platform Toolset property formsbuildto link with. It appears you can simply set the "-property" parameter already, but this exposes it so that it's a hella more obvious. Originally, python/tauthon was usingv90so the default value for this property was also set to the same value. This way it should work the same way it did originally prior to the addition.I also had to modify
PCbuild/env.bata little bit. It turns out that this script already attempted to determine the path tovcvarsall.batusing$VS90COMNTOOLS. It would runvcvarsall.batfrom Visual Studio 9.0 first, and then include any others that it could so that way Visual Studio 9.0 was mandatory. This removes that mandatory-ness since we're using the newer version of Visual Studio anyways.I added the parameter as a long-parameter, "--platform-toolset", so you can use it like:
With regards to
appveyor.yml, I think one would just need to add--platform-toolsetand make sure the image has the target version of Visual Studio on it. I'm not too familiar with appveyor, and as such I'm not sure what they have installed by default.