Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

Should not panic on insufficient container ID length #59

Open
lumjjb opened this issue Jan 31, 2019 · 2 comments
Open

Should not panic on insufficient container ID length #59

lumjjb opened this issue Jan 31, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@lumjjb
Copy link
Member

lumjjb commented Jan 31, 2019

Currently, a error is throw due to insufficient ID length. However, this is not a good way to ensure uniqueness of tap names (and on hindsight is actually counterintuitive). Instead, a hash of the container ID should be done and the slice (tap + hash)[:syscall.IFNAMSIZ-1] should be used instead.

The requirement for this is that the process to determine the name should be deterministic. Which using a standard hash function should be able to provide.

https://github.com/nabla-containers/runnc/blob/master/libcontainer/factory_nabla.go#L98

@lumjjb
Copy link
Member Author

lumjjb commented Apr 8, 2019

@InTheCloudDan is working on this! :)

@lumjjb lumjjb added the enhancement New feature or request label Apr 8, 2019
@lumjjb
Copy link
Member Author

lumjjb commented Jun 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant