Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to update ion-shell #84

Open
matthiaskrgr opened this issue May 30, 2018 · 11 comments
Open

Fails to update ion-shell #84

matthiaskrgr opened this issue May 30, 2018 · 11 comments

Comments

@matthiaskrgr
Copy link
Contributor

matthiaskrgr commented May 30, 2018

$ cargo install --git https://github.com/redox-os/ion
# wait for repo to update

$ cargo install-update -ag
Updating ion-shell from https://github.com/redox-os/ion
    Updating git repository `https://github.com/redox-os/ion`
error: could not find `ion-shell` in https://github.com/redox-os/ion

I'm not sure what the error is, manually running cargo install --git https://github.com/redox-os/ion --force does not throw any error for me. :/

@nabijaczleweli nabijaczleweli changed the title fails to update ion-shell Fails to update ion-shell May 30, 2018
@nabijaczleweli
Copy link
Owner

Sorry for the delay, but the actual command executed by cargo-update is cargo install -f --git https://github.com/redox-os/ion ion-shell (note the ion-shell package spec), so if you could re-try with that (because I can not reproduce your results :v).

@mati865
Copy link
Contributor

mati865 commented Jun 28, 2018

@nabijaczleweli caching issue on your side maybe?

$ cargo install -f --git https://github.com/redox-os/ion ion-shell
    Updating git repository `https://github.com/redox-os/ion`
error: could not find `ion-shell` in https://github.com/redox-os/ion

$ cargo install -f --git https://github.com/redox-os/ion
    Updating git repository `https://github.com/redox-os/ion`
  Installing ion-shell v1.0.0-alpha (https://github.com/redox-os/ion#171fe428)
    Updating git repository `https://gitlab.redox-os.org/redox-os/liner`
    Updating git repository `https://github.com/whitequark/rust-xdg`

@nabijaczleweli
Copy link
Owner

Despite ion-shell not building on my machine I just faked it, and:

$ cat .cargo\.crates.toml
[v1]
"cargo-update 0.8.1 (registry+https://github.com/rust-lang/crates.io-index)" = ["cargo-install-update-config.exe", "cargo-install-update.exe"]
"ion-shell 0.5.3 (git+https://github.com/redox-os/ion#f81f0ddf11b5258a52b374dc87f14f8a3857816e)" = ["ion-shell.exe"]

$ cargo install -f --git https://github.com/redox-os/ion ion-shell
    Updating git repository `https://github.com/redox-os/ion`
  Installing ion-shell v1.0.0-alpha (https://github.com/redox-os/ion#171fe428)
   Compiling winapi-x86_64-pc-windows-gnu v0.4.0
   ...
^C
$ cargo install -f --git https://github.com/redox-os/ion
    Updating git repository `https://github.com/redox-os/ion`
  Installing ion-shell v1.0.0-alpha (https://github.com/redox-os/ion#171fe428)
   Compiling winapi-x86_64-pc-windows-gnu v0.4.0
   ...
^C
$ cargo install --list
cargo-update v0.8.1:
    cargo-install-update-config.exe
    cargo-install-update.exe
ion-shell v0.5.3 (https://github.com/redox-os/ion#f81f0ddf):
    ion-shell.exe

$ target\debug\cargo-install-update install-update -g ion-shell
    Updating registry `https://github.com/rust-lang/crates.io-index`

Package  Installed  Latest  Needs update
No packages need updating.

Package    Installed                                 Latest                                    Needs update
ion-shell  f81f0ddf11b5258a52b374dc87f14f8a3857816e  171fe4280c32263894d01cfb1039808e3f00d652  Yes

Updating ion-shell from https://github.com/redox-os/ion
    Updating git repository `https://github.com/redox-os/ion`
  Installing ion-shell v1.0.0-alpha (https://github.com/redox-os/ion#171fe428)
   Compiling winapi-x86_64-pc-windows-gnu v0.4.0
   ...
^C

Anyway, this is interesting, since redox-os/ion/Cargo.toml specifies name = "ion-shell", so I'm really confused WRT why that would happen.

@mati865
Copy link
Contributor

mati865 commented Jun 28, 2018

Cannot install it on fresh OS after they made update 3 hours ago:

$ cargo install --git https://github.com/redox-os/ion
    Updating git repository `https://github.com/redox-os/ion`
error: multiple packages with binaries found: ion-shell, ion-shell-fuzz

$ cargo install --git https://github.com/redox-os/ion ion-shell
    Updating git repository `https://github.com/redox-os/ion`
error: could not find `ion-shell` in https://github.com/redox-os/ion

$ cargo install --git https://github.com/redox-os/ion ion
    Updating git repository `https://github.com/redox-os/ion`
error: could not find `ion` in https://github.com/redox-os/ion

It doesn't make any sense so it must be cargo bug.

@nabijaczleweli
Copy link
Owner

So, external and an issue there, right?

@mati865
Copy link
Contributor

mati865 commented Jun 29, 2018

Yeah but it has to be reported either to ion-shell or cargo.
Ion-shell probably should be first pick.

@matthiaskrgr
Copy link
Contributor Author

Since I made the ticket, ion moved to gitlab, as primary development place but I'm not sure if this makes a difference.

I too get a failure on
cargo install -f --git https://github.com/redox-os/ion ion-shell
or
cargo install -f --git https://github.com/redox-os/ion ion
however cloning the repo and running
cargo install --path=. --bin ion --force
seems to work...??
(which is strange since cargo install -f --git https://github.com/redox-os/ion --bin ion does not)

@mati865
Copy link
Contributor

mati865 commented Jun 29, 2018

Oh well, looks like ticket belongs to cargo repo then 😕
@matthiaskrgr do you mind filling it?

@matthiaskrgr
Copy link
Contributor Author

I looked through the preexisting cargo tickets, I think we might be a victim of this one: rust-lang/cargo#5495

@mati865
Copy link
Contributor

mati865 commented Jul 16, 2018

After reinstalling from gitlab cargo-update -ag updates ion properly.

Reinstall command:

cargo install --git https://gitlab.redox-os.org/redox-os/ion ion-shell -f

@nabijaczleweli
Copy link
Owner

hmm I'm guessing this is resolved, then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants