From 306d13d70a8ee5bbe83a22801c3b1f2a138a91e2 Mon Sep 17 00:00:00 2001
From: Charlie Kolb <charlie@n8n.io>
Date: Tue, 29 Oct 2024 14:38:58 +0100
Subject: [PATCH 1/8] enable pinning with error output and always unpin

---
 packages/editor-ui/src/components/RunData.vue    |  9 ++++++---
 .../editor-ui/src/composables/usePinnedData.ts   | 16 +++++++++-------
 2 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/packages/editor-ui/src/components/RunData.vue b/packages/editor-ui/src/components/RunData.vue
index 1c2d0b78a68ed..46099560517fd 100644
--- a/packages/editor-ui/src/components/RunData.vue
+++ b/packages/editor-ui/src/components/RunData.vue
@@ -284,6 +284,11 @@ export default defineComponent({
 				return false;
 			}
 
+			if (this.outputIndex !== 0) {
+				// Only allow pinning of the main output
+				return false;
+			}
+
 			const canPinNode = usePinnedData(this.node).canPinNode(false);
 
 			return (
@@ -1209,9 +1214,7 @@ export default defineComponent({
 <template>
 	<div :class="['run-data', $style.container]" @mouseover="activatePane">
 		<n8n-callout
-			v-if="
-				canPinData && pinnedData.hasData.value && !editMode.enabled && !isProductionExecutionPreview
-			"
+			v-if="pinnedData.hasData.value && !editMode.enabled && !isProductionExecutionPreview"
 			theme="secondary"
 			icon="thumbtack"
 			:class="$style.pinnedDataCallout"
diff --git a/packages/editor-ui/src/composables/usePinnedData.ts b/packages/editor-ui/src/composables/usePinnedData.ts
index 2ee0d046b5bc6..c5d7014c1b681 100644
--- a/packages/editor-ui/src/composables/usePinnedData.ts
+++ b/packages/editor-ui/src/composables/usePinnedData.ts
@@ -85,14 +85,16 @@ export function usePinnedData(
 		if (!nodeType || (checkDataEmpty && dataToPin.length === 0)) return false;
 
 		const workflow = workflowsStore.getCurrentWorkflow();
-		const outputs = NodeHelpers.getNodeOutputs(workflow, targetNode, nodeType);
-		const mainOutputs = outputs.filter((output) =>
-			typeof output === 'string'
-				? output === NodeConnectionType.Main
-				: output.type === NodeConnectionType.Main,
-		);
+		const mainOutputs = NodeHelpers.getNodeOutputs(workflow, targetNode, nodeType)
+			.map((output) => (typeof output === 'string' ? { type: output } : output))
+			.filter((output) => output.type === NodeConnectionType.Main);
+
+		// Outputs are pinnable if there is exactly one main output and optionally one error output
+		const pinnableMainOutputs =
+			mainOutputs.length === 1 ||
+			(mainOutputs.length === 2 && mainOutputs[1]?.category === 'error');
 
-		return mainOutputs.length === 1 && !PIN_DATA_NODE_TYPES_DENYLIST.includes(targetNode.type);
+		return pinnableMainOutputs && !PIN_DATA_NODE_TYPES_DENYLIST.includes(targetNode.type);
 	}
 
 	function isValidJSON(data: string): boolean {

From dd354ff7b5dc59dd186868dae368e8a2e0c78c67 Mon Sep 17 00:00:00 2001
From: Charlie Kolb <charlie@n8n.io>
Date: Thu, 31 Oct 2024 11:24:39 +0100
Subject: [PATCH 2/8] Add tests

---
 .../__tests__/usePinnedData.test.ts           | 77 ++++++++++++++++++-
 1 file changed, 76 insertions(+), 1 deletion(-)

diff --git a/packages/editor-ui/src/composables/__tests__/usePinnedData.test.ts b/packages/editor-ui/src/composables/__tests__/usePinnedData.test.ts
index 499c3714965a0..affde4cabd939 100644
--- a/packages/editor-ui/src/composables/__tests__/usePinnedData.test.ts
+++ b/packages/editor-ui/src/composables/__tests__/usePinnedData.test.ts
@@ -3,9 +3,10 @@ import { setActivePinia, createPinia } from 'pinia';
 import { ref } from 'vue';
 import { usePinnedData } from '@/composables/usePinnedData';
 import type { INodeUi } from '@/Interface';
-import { MAX_PINNED_DATA_SIZE } from '@/constants';
+import { HTTP_REQUEST_NODE_TYPE, IF_NODE_TYPE, MAX_PINNED_DATA_SIZE } from '@/constants';
 import { useWorkflowsStore } from '@/stores/workflows.store';
 import { useTelemetry } from '@/composables/useTelemetry';
+import { NodeConnectionType, type INodeTypeDescription } from 'n8n-workflow';
 
 vi.mock('@/composables/useToast', () => ({ useToast: vi.fn(() => ({ showError: vi.fn() })) }));
 vi.mock('@/composables/useI18n', () => ({
@@ -17,6 +18,13 @@ vi.mock('@/composables/useExternalHooks', () => ({
 	})),
 }));
 
+const getNodeType = vi.fn();
+vi.mock('@/stores/nodeTypes.store', () => ({
+	useNodeTypesStore: vi.fn(() => ({
+		getNodeType,
+	})),
+}));
+
 describe('usePinnedData', () => {
 	beforeEach(() => {
 		setActivePinia(createPinia());
@@ -133,4 +141,71 @@ describe('usePinnedData', () => {
 			expect(spy).toHaveBeenCalled();
 		});
 	});
+
+	describe('canPinData()', () => {
+		afterEach(() => {
+			vi.clearAllMocks();
+		});
+
+		it('allows pin on single output', async () => {
+			const node = ref({
+				name: 'single output node',
+				typeVersion: 1,
+				type: HTTP_REQUEST_NODE_TYPE,
+
+				parameters: {},
+				onError: 'stopWorkflow',
+			} as INodeUi);
+			getNodeType.mockReturnValue(makeNodeType([NodeConnectionType.Main], HTTP_REQUEST_NODE_TYPE));
+
+			const { canPinNode } = usePinnedData(node);
+
+			expect(canPinNode()).toBe(true);
+		});
+
+		it('allows pin on one main and one error output', async () => {
+			const node = ref({
+				name: 'single output node',
+				typeVersion: 1,
+				type: HTTP_REQUEST_NODE_TYPE,
+				parameters: {},
+				onError: 'continueErrorOutput',
+			} as INodeUi);
+			getNodeType.mockReturnValue(makeNodeType([NodeConnectionType.Main], HTTP_REQUEST_NODE_TYPE));
+
+			const { canPinNode } = usePinnedData(node);
+
+			expect(canPinNode()).toBe(true);
+		});
+
+		it('does not allow pin on two main outputs', async () => {
+			const node = ref({
+				name: 'single output node',
+				typeVersion: 1,
+				type: IF_NODE_TYPE,
+				parameters: {},
+				onError: 'stopWorkflow',
+			} as INodeUi);
+			getNodeType.mockReturnValue(
+				makeNodeType([NodeConnectionType.Main, NodeConnectionType.Main], IF_NODE_TYPE),
+			);
+
+			const { canPinNode } = usePinnedData(node);
+
+			expect(canPinNode()).toBe(false);
+		});
+	});
 });
+
+const makeNodeType = (outputs: NodeConnectionType[], name: string) =>
+	({
+		displayName: name,
+		name,
+		version: [1],
+		inputs: [],
+		outputs,
+		properties: [],
+		defaults: { color: '', name: '' },
+		group: [],
+		description: '',
+	}) as INodeTypeDescription;

From aae7ccc8ed4236bd5191ec41958b22f7aa88ea1a Mon Sep 17 00:00:00 2001
From: Charlie Kolb <charlie@n8n.io>
Date: Mon, 4 Nov 2024 13:28:29 +0100
Subject: [PATCH 3/8] Update
 packages/editor-ui/src/composables/usePinnedData.ts

Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
---
 packages/editor-ui/src/composables/usePinnedData.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/editor-ui/src/composables/usePinnedData.ts b/packages/editor-ui/src/composables/usePinnedData.ts
index c5d7014c1b681..354c44c76e1c3 100644
--- a/packages/editor-ui/src/composables/usePinnedData.ts
+++ b/packages/editor-ui/src/composables/usePinnedData.ts
@@ -87,7 +87,7 @@ export function usePinnedData(
 		const workflow = workflowsStore.getCurrentWorkflow();
 		const mainOutputs = NodeHelpers.getNodeOutputs(workflow, targetNode, nodeType)
 			.map((output) => (typeof output === 'string' ? { type: output } : output))
-			.filter((output) => output.type === NodeConnectionType.Main);
+			.filter((output) => output.type === NodeConnectionType.Main && output.category !== 'error');
 
 		// Outputs are pinnable if there is exactly one main output and optionally one error output
 		const pinnableMainOutputs =

From 1cb39c776a36c00a0914707b140f6a848f1a660c Mon Sep 17 00:00:00 2001
From: Charlie Kolb <charlie@n8n.io>
Date: Tue, 5 Nov 2024 09:28:06 +0100
Subject: [PATCH 4/8] PR Feedback

---
 packages/editor-ui/src/components/RunData.vue |  8 +-----
 .../src/composables/usePinnedData.test.ts     | 14 ++++++++++
 .../src/composables/usePinnedData.ts          | 28 ++++++++++++-------
 packages/workflow/src/Interfaces.ts           | 21 +++++---------
 4 files changed, 40 insertions(+), 31 deletions(-)

diff --git a/packages/editor-ui/src/components/RunData.vue b/packages/editor-ui/src/components/RunData.vue
index 9644eb7ec78fb..afa102ed52b79 100644
--- a/packages/editor-ui/src/components/RunData.vue
+++ b/packages/editor-ui/src/components/RunData.vue
@@ -288,13 +288,7 @@ export default defineComponent({
 				return false;
 			}
 
-			if (this.outputIndex !== 0) {
-				// Only allow pinning of the main output
-				return false;
-			}
-
-			const canPinNode = usePinnedData(this.node).canPinNode(false);
-
+			const canPinNode = usePinnedData(this.node).canPinNode(false, this.currentOutputIndex);
 			return (
 				canPinNode &&
 				!this.isPaneTypeInput &&
diff --git a/packages/editor-ui/src/composables/usePinnedData.test.ts b/packages/editor-ui/src/composables/usePinnedData.test.ts
index affde4cabd939..b3da7b8dba463 100644
--- a/packages/editor-ui/src/composables/usePinnedData.test.ts
+++ b/packages/editor-ui/src/composables/usePinnedData.test.ts
@@ -161,6 +161,10 @@ describe('usePinnedData', () => {
 			const { canPinNode } = usePinnedData(node);
 
 			expect(canPinNode()).toBe(true);
+			expect(canPinNode(false, 0)).toBe(true);
+			// validate out of range index
+			expect(canPinNode(false, 1)).toBe(false);
+			expect(canPinNode(false, -1)).toBe(false);
 		});
 
 		it('allows pin on one main and one error output', async () => {
@@ -176,6 +180,11 @@ describe('usePinnedData', () => {
 			const { canPinNode } = usePinnedData(node);
 
 			expect(canPinNode()).toBe(true);
+			expect(canPinNode(false, 0)).toBe(true);
+			expect(canPinNode(false, 1)).toBe(false);
+			// validate out of range index
+			expect(canPinNode(false, 2)).toBe(false);
+			expect(canPinNode(false, -1)).toBe(false);
 		});
 
 		it('does not allow pin on two main outputs', async () => {
@@ -193,6 +202,11 @@ describe('usePinnedData', () => {
 			const { canPinNode } = usePinnedData(node);
 
 			expect(canPinNode()).toBe(false);
+			expect(canPinNode(false, 0)).toBe(false);
+			expect(canPinNode(false, 1)).toBe(false);
+			// validate out of range index
+			expect(canPinNode(false, 2)).toBe(false);
+			expect(canPinNode(false, -1)).toBe(false);
 		});
 	});
 });
diff --git a/packages/editor-ui/src/composables/usePinnedData.ts b/packages/editor-ui/src/composables/usePinnedData.ts
index 354c44c76e1c3..c940f5c32265d 100644
--- a/packages/editor-ui/src/composables/usePinnedData.ts
+++ b/packages/editor-ui/src/composables/usePinnedData.ts
@@ -75,9 +75,9 @@ export function usePinnedData(
 		);
 	});
 
-	function canPinNode(checkDataEmpty = false) {
+	function canPinNode(checkDataEmpty = false, outputIndex?: number) {
 		const targetNode = unref(node);
-		if (targetNode === null) return false;
+		if (targetNode === null || PIN_DATA_NODE_TYPES_DENYLIST.includes(targetNode.type)) return false;
 
 		const nodeType = useNodeTypesStore().getNodeType(targetNode.type, targetNode.typeVersion);
 		const dataToPin = getInputDataWithPinned(targetNode);
@@ -85,16 +85,24 @@ export function usePinnedData(
 		if (!nodeType || (checkDataEmpty && dataToPin.length === 0)) return false;
 
 		const workflow = workflowsStore.getCurrentWorkflow();
-		const mainOutputs = NodeHelpers.getNodeOutputs(workflow, targetNode, nodeType)
-			.map((output) => (typeof output === 'string' ? { type: output } : output))
-			.filter((output) => output.type === NodeConnectionType.Main && output.category !== 'error');
+		const outputs = NodeHelpers.getNodeOutputs(workflow, targetNode, nodeType).map((output) =>
+			typeof output === 'string' ? { type: output } : output,
+		);
+
+		const mainOutputs = outputs.filter(
+			(output) => output.type === NodeConnectionType.Main && output.category !== 'error',
+		);
 
-		// Outputs are pinnable if there is exactly one main output and optionally one error output
-		const pinnableMainOutputs =
-			mainOutputs.length === 1 ||
-			(mainOutputs.length === 2 && mainOutputs[1]?.category === 'error');
+		let indexAcceptable = true;
+		if (outputIndex !== undefined) {
+			const output = outputs[outputIndex];
+			if (output === undefined) return false;
+
+			indexAcceptable =
+				output && output.type === NodeConnectionType.Main && output.category !== 'error';
+		}
 
-		return pinnableMainOutputs && !PIN_DATA_NODE_TYPES_DENYLIST.includes(targetNode.type);
+		return mainOutputs.length === 1 && indexAcceptable;
 	}
 
 	function isValidJSON(data: string): boolean {
diff --git a/packages/workflow/src/Interfaces.ts b/packages/workflow/src/Interfaces.ts
index 4f92a219e6234..80140d93a2092 100644
--- a/packages/workflow/src/Interfaces.ts
+++ b/packages/workflow/src/Interfaces.ts
@@ -731,11 +731,8 @@ export interface ICredentialTestFunctions {
 	};
 }
 
-interface BaseHelperFunctions {
+export interface BaseHelperFunctions {
 	createDeferredPromise: <T = void>() => IDeferredPromise<T>;
-}
-
-interface JsonHelperFunctions {
 	returnJsonArray(jsonData: IDataObject | IDataObject[]): INodeExecutionData[];
 }
 
@@ -756,6 +753,7 @@ export interface BinaryHelperFunctions {
 		mimeType?: string,
 	): Promise<IBinaryData>;
 	setBinaryDataBuffer(data: IBinaryData, binaryData: Buffer): Promise<IBinaryData>;
+	/** @deprecated */
 	copyBinaryFile(): Promise<never>;
 	binaryToBuffer(body: Buffer | Readable): Promise<Buffer>;
 	binaryToString(body: Buffer | Readable, encoding?: BufferEncoding): Promise<string>;
@@ -985,8 +983,7 @@ export type IExecuteFunctions = ExecuteFunctions.GetNodeParameterFn &
 			BinaryHelperFunctions &
 			DeduplicationHelperFunctions &
 			FileSystemHelperFunctions &
-			SSHTunnelFunctions &
-			JsonHelperFunctions & {
+			SSHTunnelFunctions & {
 				normalizeItems(items: INodeExecutionData | INodeExecutionData[]): INodeExecutionData[];
 				constructExecutionMetaData(
 					inputData: INodeExecutionData[],
@@ -1081,8 +1078,7 @@ export interface IPollFunctions
 	helpers: RequestHelperFunctions &
 		BaseHelperFunctions &
 		BinaryHelperFunctions &
-		SchedulingFunctions &
-		JsonHelperFunctions;
+		SchedulingFunctions;
 }
 
 export interface ITriggerFunctions
@@ -1102,8 +1098,7 @@ export interface ITriggerFunctions
 		BaseHelperFunctions &
 		BinaryHelperFunctions &
 		SSHTunnelFunctions &
-		SchedulingFunctions &
-		JsonHelperFunctions;
+		SchedulingFunctions;
 }
 
 export interface IHookFunctions
@@ -1140,10 +1135,7 @@ export interface IWebhookFunctions extends FunctionsBaseWithRequiredKeys<'getMod
 	getResponseObject(): express.Response;
 	getWebhookName(): string;
 	nodeHelpers: NodeHelperFunctions;
-	helpers: RequestHelperFunctions &
-		BaseHelperFunctions &
-		BinaryHelperFunctions &
-		JsonHelperFunctions;
+	helpers: RequestHelperFunctions & BaseHelperFunctions & BinaryHelperFunctions;
 }
 
 export interface INodeCredentialsDetails {
@@ -1641,6 +1633,7 @@ export abstract class Node {
 	abstract description: INodeTypeDescription;
 	execute?(context: IExecuteFunctions): Promise<INodeExecutionData[][]>;
 	webhook?(context: IWebhookFunctions): Promise<IWebhookResponseData>;
+	poll?(context: IPollFunctions): Promise<INodeExecutionData[][] | null>;
 }
 
 export interface IVersionedNodeType {

From 4f958858eaa2eb85d218435b3e29f0f3cbdc30e7 Mon Sep 17 00:00:00 2001
From: Charlie Kolb <charlie@n8n.io>
Date: Tue, 5 Nov 2024 09:32:56 +0100
Subject: [PATCH 5/8] throw error instead

---
 .../editor-ui/src/composables/usePinnedData.test.ts  | 12 ++++++------
 packages/editor-ui/src/composables/usePinnedData.ts  |  3 ++-
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/packages/editor-ui/src/composables/usePinnedData.test.ts b/packages/editor-ui/src/composables/usePinnedData.test.ts
index b3da7b8dba463..afd5d47b63013 100644
--- a/packages/editor-ui/src/composables/usePinnedData.test.ts
+++ b/packages/editor-ui/src/composables/usePinnedData.test.ts
@@ -163,8 +163,8 @@ describe('usePinnedData', () => {
 			expect(canPinNode()).toBe(true);
 			expect(canPinNode(false, 0)).toBe(true);
 			// validate out of range index
-			expect(canPinNode(false, 1)).toBe(false);
-			expect(canPinNode(false, -1)).toBe(false);
+			expect(() => canPinNode(false, 1)).toThrow();
+			expect(() => canPinNode(false, -1)).toThrow();
 		});
 
 		it('allows pin on one main and one error output', async () => {
@@ -183,8 +183,8 @@ describe('usePinnedData', () => {
 			expect(canPinNode(false, 0)).toBe(true);
 			expect(canPinNode(false, 1)).toBe(false);
 			// validate out of range index
-			expect(canPinNode(false, 2)).toBe(false);
-			expect(canPinNode(false, -1)).toBe(false);
+			expect(() => canPinNode(false, 2)).toThrow();
+			expect(() => canPinNode(false, -1)).toThrow();
 		});
 
 		it('does not allow pin on two main outputs', async () => {
@@ -205,8 +205,8 @@ describe('usePinnedData', () => {
 			expect(canPinNode(false, 0)).toBe(false);
 			expect(canPinNode(false, 1)).toBe(false);
 			// validate out of range index
-			expect(canPinNode(false, 2)).toBe(false);
-			expect(canPinNode(false, -1)).toBe(false);
+			expect(() => canPinNode(false, 2)).toThrow();
+			expect(() => canPinNode(false, -1)).toThrow();
 		});
 	});
 });
diff --git a/packages/editor-ui/src/composables/usePinnedData.ts b/packages/editor-ui/src/composables/usePinnedData.ts
index c940f5c32265d..e698eca822b13 100644
--- a/packages/editor-ui/src/composables/usePinnedData.ts
+++ b/packages/editor-ui/src/composables/usePinnedData.ts
@@ -96,7 +96,8 @@ export function usePinnedData(
 		let indexAcceptable = true;
 		if (outputIndex !== undefined) {
 			const output = outputs[outputIndex];
-			if (output === undefined) return false;
+			if (output === undefined)
+				throw new Error(`Out of bounds index ${outputIndex} provided to canPinNode`);
 
 			indexAcceptable =
 				output && output.type === NodeConnectionType.Main && output.category !== 'error';

From a63af7f6d6af5d42cb85ce5ab9c4d01237e017c2 Mon Sep 17 00:00:00 2001
From: Charlie Kolb <charlie@n8n.io>
Date: Tue, 5 Nov 2024 09:37:03 +0100
Subject: [PATCH 6/8] self review

---
 packages/editor-ui/src/components/RunData.vue       | 1 +
 packages/editor-ui/src/composables/usePinnedData.ts | 7 ++++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/packages/editor-ui/src/components/RunData.vue b/packages/editor-ui/src/components/RunData.vue
index afa102ed52b79..8dabf805e1c85 100644
--- a/packages/editor-ui/src/components/RunData.vue
+++ b/packages/editor-ui/src/components/RunData.vue
@@ -289,6 +289,7 @@ export default defineComponent({
 			}
 
 			const canPinNode = usePinnedData(this.node).canPinNode(false, this.currentOutputIndex);
+
 			return (
 				canPinNode &&
 				!this.isPaneTypeInput &&
diff --git a/packages/editor-ui/src/composables/usePinnedData.ts b/packages/editor-ui/src/composables/usePinnedData.ts
index e698eca822b13..99ea646c75a07 100644
--- a/packages/editor-ui/src/composables/usePinnedData.ts
+++ b/packages/editor-ui/src/composables/usePinnedData.ts
@@ -94,13 +94,14 @@ export function usePinnedData(
 		);
 
 		let indexAcceptable = true;
+
 		if (outputIndex !== undefined) {
 			const output = outputs[outputIndex];
-			if (output === undefined)
+
+			if (outputs[outputIndex] === undefined)
 				throw new Error(`Out of bounds index ${outputIndex} provided to canPinNode`);
 
-			indexAcceptable =
-				output && output.type === NodeConnectionType.Main && output.category !== 'error';
+			indexAcceptable = output.type === NodeConnectionType.Main && output.category !== 'error';
 		}
 
 		return mainOutputs.length === 1 && indexAcceptable;

From f03b325e21b4b89f3ec40a046beb335ffdeb977a Mon Sep 17 00:00:00 2001
From: Charlie Kolb <charlie@n8n.io>
Date: Tue, 5 Nov 2024 10:33:33 +0100
Subject: [PATCH 7/8] more tests

---
 .../src/composables/usePinnedData.test.ts     | 28 ++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/packages/editor-ui/src/composables/usePinnedData.test.ts b/packages/editor-ui/src/composables/usePinnedData.test.ts
index afd5d47b63013..14d33b0c61aff 100644
--- a/packages/editor-ui/src/composables/usePinnedData.test.ts
+++ b/packages/editor-ui/src/composables/usePinnedData.test.ts
@@ -6,7 +6,7 @@ import type { INodeUi } from '@/Interface';
 import { HTTP_REQUEST_NODE_TYPE, IF_NODE_TYPE, MAX_PINNED_DATA_SIZE } from '@/constants';
 import { useWorkflowsStore } from '@/stores/workflows.store';
 import { useTelemetry } from '@/composables/useTelemetry';
-import { NodeConnectionType, type INodeTypeDescription } from 'n8n-workflow';
+import { NodeConnectionType, STICKY_NODE_TYPE, type INodeTypeDescription } from 'n8n-workflow';
 
 vi.mock('@/composables/useToast', () => ({ useToast: vi.fn(() => ({ showError: vi.fn() })) }));
 vi.mock('@/composables/useI18n', () => ({
@@ -208,6 +208,32 @@ describe('usePinnedData', () => {
 			expect(() => canPinNode(false, 2)).toThrow();
 			expect(() => canPinNode(false, -1)).toThrow();
 		});
+
+		it('does not allow pin on denylisted node', async () => {
+			const node = ref({
+				name: 'single output node',
+				typeVersion: 1,
+				type: STICKY_NODE_TYPE,
+			} as INodeUi);
+			const { canPinNode } = usePinnedData(node);
+
+			expect(canPinNode()).toBe(false);
+			expect(canPinNode(false, 0)).toBe(false);
+		});
+
+		it('does not allow pin with checkDataEmpty and no pin', async () => {
+			const node = ref({
+				name: 'single output node',
+				typeVersion: 1,
+				type: HTTP_REQUEST_NODE_TYPE,
+			} as INodeUi);
+			getNodeType.mockReturnValue(makeNodeType([NodeConnectionType.Main], HTTP_REQUEST_NODE_TYPE));
+
+			const { canPinNode } = usePinnedData(node);
+
+			expect(canPinNode(true)).toBe(false);
+			expect(canPinNode(true, 0)).toBe(false);
+		});
 	});
 });
 

From 4db633a2ec7be72ea15698175efee627d768d449 Mon Sep 17 00:00:00 2001
From: Charlie Kolb <charlie@n8n.io>
Date: Wed, 6 Nov 2024 10:08:34 +0100
Subject: [PATCH 8/8] PR Feedback

---
 .../src/composables/usePinnedData.test.ts     | 28 +++++++++++++++----
 .../src/composables/usePinnedData.ts          |  3 +-
 2 files changed, 23 insertions(+), 8 deletions(-)

diff --git a/packages/editor-ui/src/composables/usePinnedData.test.ts b/packages/editor-ui/src/composables/usePinnedData.test.ts
index 14d33b0c61aff..cc83ce0ed6578 100644
--- a/packages/editor-ui/src/composables/usePinnedData.test.ts
+++ b/packages/editor-ui/src/composables/usePinnedData.test.ts
@@ -163,8 +163,8 @@ describe('usePinnedData', () => {
 			expect(canPinNode()).toBe(true);
 			expect(canPinNode(false, 0)).toBe(true);
 			// validate out of range index
-			expect(() => canPinNode(false, 1)).toThrow();
-			expect(() => canPinNode(false, -1)).toThrow();
+			expect(canPinNode(false, 1)).toBe(false);
+			expect(canPinNode(false, -1)).toBe(false);
 		});
 
 		it('allows pin on one main and one error output', async () => {
@@ -183,8 +183,8 @@ describe('usePinnedData', () => {
 			expect(canPinNode(false, 0)).toBe(true);
 			expect(canPinNode(false, 1)).toBe(false);
 			// validate out of range index
-			expect(() => canPinNode(false, 2)).toThrow();
-			expect(() => canPinNode(false, -1)).toThrow();
+			expect(canPinNode(false, 2)).toBe(false);
+			expect(canPinNode(false, -1)).toBe(false);
 		});
 
 		it('does not allow pin on two main outputs', async () => {
@@ -205,8 +205,8 @@ describe('usePinnedData', () => {
 			expect(canPinNode(false, 0)).toBe(false);
 			expect(canPinNode(false, 1)).toBe(false);
 			// validate out of range index
-			expect(() => canPinNode(false, 2)).toThrow();
-			expect(() => canPinNode(false, -1)).toThrow();
+			expect(canPinNode(false, 2)).toBe(false);
+			expect(canPinNode(false, -1)).toBe(false);
 		});
 
 		it('does not allow pin on denylisted node', async () => {
@@ -234,6 +234,22 @@ describe('usePinnedData', () => {
 			expect(canPinNode(true)).toBe(false);
 			expect(canPinNode(true, 0)).toBe(false);
 		});
+
+		it('does not allow pin without output', async () => {
+			const node = ref({
+				name: 'zero output node',
+				typeVersion: 1,
+				type: 'n8n-nodes-base.stopAndError',
+			} as INodeUi);
+			getNodeType.mockReturnValue(makeNodeType([], 'n8n-nodes-base.stopAndError'));
+
+			const { canPinNode } = usePinnedData(node);
+
+			expect(canPinNode()).toBe(false);
+			expect(canPinNode(false, 0)).toBe(false);
+			expect(canPinNode(false, -1)).toBe(false);
+			expect(canPinNode(false, 1)).toBe(false);
+		});
 	});
 });
 
diff --git a/packages/editor-ui/src/composables/usePinnedData.ts b/packages/editor-ui/src/composables/usePinnedData.ts
index 99ea646c75a07..46d33fc6296d5 100644
--- a/packages/editor-ui/src/composables/usePinnedData.ts
+++ b/packages/editor-ui/src/composables/usePinnedData.ts
@@ -98,8 +98,7 @@ export function usePinnedData(
 		if (outputIndex !== undefined) {
 			const output = outputs[outputIndex];
 
-			if (outputs[outputIndex] === undefined)
-				throw new Error(`Out of bounds index ${outputIndex} provided to canPinNode`);
+			if (outputs[outputIndex] === undefined) return false;
 
 			indexAcceptable = output.type === NodeConnectionType.Main && output.category !== 'error';
 		}