fix(editor): Render credentials editable when opening them from the node view #9678
+32
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode view Use the fetched credential instead of loading it from the store.
n8n-assistant
bot
added
n8n team
krynble
previously approved these changes
Jun 10, 2024
despairblue
force-pushed
the
pay-1664-credentials-cant-be-accessed-from-workflows
branch
from
559d00c to
0708a87
Compare
krynble
approved these changes
Jun 11, 2024
|
|
2 flaky tests on run #5444 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
20-workflow-executions.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Current Workflow Executions > should auto load more items if there is space and auto scroll |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9678 ↗︎
despairblue
force-pushed
the
pay-1664-credentials-cant-be-accessed-from-workflows
branch
from
0708a87 to
5bdd315
Compare
krynble
approved these changes
Jun 11, 2024
|
|
netroy
added
the
release/backport
|
✅ All Cypress E2E specs passed |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The modal is already fetching the up to date credential to get the data.
But then it wants to use the credential from the store for everything else.
I changed this so that it uses the fetched credential for everything.
TODO:
Related tickets and issues
https://linear.app/n8n/issue/PAY-1664/credentials-cant-be-accessed-from-workflows
Review / Merge checklist
(no-changelog)otherwise. (conventions)