fix(Slack Node): Do not try to parse block if it's already object #9643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
node/improvement
netroy
requested changes
Jun 6, 2024
…slack-node-blocks-explicitly-expects-json-string
…slack-node-blocks-explicitly-expects-json-string
…slack-node-blocks-explicitly-expects-json-string
…-blocks-explicitly-expects-json-string
netroy
approved these changes
Jun 18, 2024
| @@ -162,7 +162,7 @@ export function getMessageContent( | |||
| }; | |||
| break; | |||
| case 'block': | |||
| content = jsonParse(this.getNodeParameter('blocksUi', i) as string); | |||
| content = this.getNodeParameter('blocksUi', i, {}, { ensureType: 'object' }) as IDataObject; | |||
There was a problem hiding this comment.
This isn't ideal, but considering the state of type-safety in this package, I think this might be the most realistic option right now .
|
✅ No visual regressions found. |
|
|
3 flaky tests on run #5554 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
10-undo-redo.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo renaming node using NDV |
Test Replay
Screenshots
Video
|
|
20-workflow-executions.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Current Workflow Executions > should auto load more items if there is space and auto scroll |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9643 ↗︎
|
✅ All Cypress E2E specs passed |
michael-radency
deleted the
node-647-slack-node-blocks-explicitly-expects-json-string
branch
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…n-io#9643) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…n-io#9643) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Slack Node Blocks explicitly expects JSON String
Related tickets and issues
https://linear.app/n8n/issue/NODE-647/slack-node-blocks-explicitly-expects-json-string