Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GraphQL Node): Fix request format JSON error #8646

Merged
merged 4 commits into from
Feb 15, 2024
Merged

fix(GraphQL Node): Fix request format JSON error #8646

merged 4 commits into from
Feb 15, 2024

Conversation

maspio
Copy link
Contributor

@maspio maspio commented Feb 15, 2024 •
edited by netroy
Loading

Summary

The GraphQL node does not work for json body requests. Bug was introduced in [email protected] in PR-8563.

image

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Feb 15, 2024
@maspio maspio marked this pull request as ready for review February 15, 2024 16:10
netroy
netroy previously approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

netroy
netroy previously approved these changes Feb 15, 2024
View reviewed changes
@cypress Cypress
Copy link

cypress bot commented Feb 15, 2024 •
edited
Loading

3 flaky tests on run #4124 ↗︎

0 343 5 0 Flakiness 3

Details:

🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project: n8n Commit: bd4b50cf08
Status: Passed Duration: 03:47 💡
Started: Feb 16, 2024 3:10 AM Ended: Feb 16, 2024 3:14 AM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  28-debug.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Debug > should be able to debug executions Test Replay Screenshots Video
Flakiness  38-custom-template-repository.cy.ts • 1 flaky test

View Output Video

Test Artifacts
In-app templates repository > should save template id with the workflow Test Replay Screenshots Video

Review all test suite changes for PR #8646 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@netroy netroy merged commit bd4b50c into master Feb 15, 2024
25 of 28 checks passed
@netroy netroy deleted the fix-graphql-json-body-error branch February 15, 2024 16:49
netroy pushed a commit that referenced this pull request Feb 16, 2024
@maspio @netroy
fix(GraphQL Node): Fix request format JSON error (#8646)
1e0370c
@github-actions github-actions bot mentioned this pull request Feb 16, 2024
Merged
@janober
Copy link
Member

janober commented Feb 16, 2024

Got released with [email protected]

despairblue pushed a commit that referenced this pull request Feb 16, 2024
@maspio @despairblue
fix(GraphQL Node): Fix request format JSON error (#8646)
2c773b4
@github-actions github-actions bot mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maspio @janober @netroy