feat: Add telemetry event when users click on templates link #8625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
tomi
approved these changes
Feb 14, 2024
| @@ -419,6 +422,14 @@ export default defineComponent({ | |||
| }, | |||
| async handleSelect(key: string) { | |||
| switch (key) { | |||
| case 'templates': | |||
| if ( | |||
| this.settingsStore.isTemplatesEnabled && | |||
There was a problem hiding this comment.
Is this also related to the custom templates host? Or is there an option to hide the templates altogether?
There was a problem hiding this comment.
The sidebar option will be different for custom template host but it will have the same key. So this will prevent this event from being sent if users still have in-app templates (custom host)
1 flaky test on run #4096 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8625 ↗︎
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
despairblue
pushed a commit
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds telemetry event for new template link clicks.
Related tickets and issues
Related to ADO-1789
Review / Merge checklist
(no-changelog)otherwise. (conventions)