fix(Wait Node): Account for workflow timezone in Wait node datetime #8578
Conversation
n8n-assistant
bot
added
core
ivov
changed the title
| waitTill = new Date(new Date().getTime() + waitAmount); | ||
| const original = new Date(new Date().getTime() + waitAmount); | ||
|
|
||
| waitTill = DateTime.fromISO(original.toISOString().slice(0, -1)).toUTC().toJSDate(); |
There was a problem hiding this comment.
Is it worth considering moving the toUtcDate to the nodes package as well as its tests? WDYT?
There was a problem hiding this comment.
Actually I just tested it now, and it looks real bad. It now takes into account the timezone, so it seems it startec picking up America/New York so instead of my workflows waiting 10 minutes, they now way 5 hours and 10 minutes, which is even worse 😓
But to make things even more interesting, I changed the workflow's timezone, and it's also being completely ignored.
There was a problem hiding this comment.
Can you elaborate? This is how I tested:
- Selected 12:00 with workflow set at UTC-5 → Stored as 17:00 UTC in DB
- Selected +2h with workflow set at 10:40 UTC-5 → Stored as 17:40 UTC in DB
These are what I'd expect to be correct. What am I missing?
|
|
||
| waitTill = new Date(dateTime); | ||
| waitTill = DateTime.fromFormat(dateTimeStr, "yyyy-MM-dd'T'HH:mm:ss", { |
There was a problem hiding this comment.
Fix timezone only for specific points in time, where 4pm is something in UK vs Berlin.
|
✅ All Cypress E2E specs passed |
2 flaky tests on run #4102 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
13-pinning.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Data pinning > Should be able to reference paired items in a node located before pinned data |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8578 ↗︎
|
Got released with |
…8578) Co-authored-by: Omar Ajoue <[email protected]>
https://linear.app/n8n/issue/PAY-1341