feat: Add support for AI log streaming #8526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
OlegIvaniv
changed the title
krynble
force-pushed
the
feature/ai-log-streaming
branch
from
6bb7edb to
aa4ad81
Compare
OlegIvaniv
approved these changes
Feb 9, 2024
3 flaky tests on run #4058 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
13-pinning.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Data pinning > Should be able to reference paired items in a node located before pinned data |
Test Replay
Screenshots
Video
|
|
19-execution.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Execution > should test manual workflow stop |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8526 ↗︎
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
cstuncsik
pushed a commit
that referenced
this pull request
Feb 17, 2024
Co-authored-by: Oleg Ivaniv <[email protected]>
OlegIvaniv
added a commit
that referenced
this pull request
Feb 19, 2024
Co-authored-by: Oleg Ivaniv <[email protected]>
ivov
added a commit
that referenced
this pull request
Sep 11, 2024
This PR brings the AI events in line with all other log streaming events in the relay, breaks a dependency cycle in `WorkflowExecuteAdditionalData`, stops awaiting on log streaming during the AI nodes execution, and adds tests for all AI log streaming events. Notes: - Removed `n8n.ai.output.parser.get.instructions` as it was unused. - `cli` does not import `workflow` so I had to duplicate two small types. Once we have a common types package this should no longer be an issue. Follow-up to: #8526
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds AI-related log streaming events. The following events were implemented:
Related tickets and issues
Review / Merge checklist
(no-changelog)otherwise. (conventions)