fix(Merge Node): Fixing how paired items are handled in the merge node, when choosing a branch and selecting to return an empty object #8479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens only when choosing a branch and selecting to return an empty object. I stumbled on this while attempting to solve the level 2 course.
n8n-assistant
bot
added
n8n team
despairblue
changed the title
despairblue
force-pushed
the
fix-paired-items-being-broken-merge-node
branch
from
c00c8db to
26c00b1
Compare
despairblue
commented
Feb 13, 2024
Comment on lines
607
to
626
| // TODO: was necessary to satisfies types. | ||
| // I'm wondering if there is already a function that does exactly that? That turns | ||
| // Array<IPairedItemData | IPairedItemData[] | number | undefined> -> IPairedItemData[] | ||
| // or | ||
| // IPairedItemData | IPairedItemData[] | number | undefined -> IPairedItemData | undefined | ||
| function numberToPairedItem( | ||
| possiblyPairedItems: Array<INodeExecutionData['pairedItem']>, | ||
| ): IPairedItemData[] { | ||
| return possiblyPairedItems.reduce((pairedItems: IPairedItemData[], pairedItem) => { | ||
| if (typeof pairedItem === 'number') { | ||
| pairedItems.push({ item: pairedItem }); | ||
| } else if (Array.isArray(pairedItem)) { | ||
| pairedItems.push(...pairedItem); | ||
| } else if (pairedItem) { | ||
| pairedItems.push(pairedItem); | ||
| } | ||
|
|
||
| return pairedItems; | ||
| }, [] as IPairedItemData[]); | ||
| } |
There was a problem hiding this comment.
Is there a better way to do this?
Does this helper exist anywhere? If not, should I move it to some utility module?
There was a problem hiding this comment.
@despairblue I guess if this is something that may come up again it would be handy to have a utility function for it so we can reuse it but I am not sure
There was a problem hiding this comment.
@Joffcom There was a function already that does this, just had to combine it with a flatMap :)
…d-items-being-broken-merge-node
despairblue
changed the title
|
✅ All Cypress E2E specs passed |
1 flaky test on run #4088 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8479 ↗︎
Merged
|
Got released with |
despairblue
added a commit
that referenced
this pull request
Feb 16, 2024
…e, when choosing a branch and selecting to return an empty object (#8479) Co-authored-by: Michael Kret <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Referencing items before a merge node was broken when you chose to return a single empty object due to how the paired items were handled.
I stumbled on this while attempting to solve the level 2 course.
Related tickets and issues
Review / Merge checklist
(no-changelog)otherwise. (conventions)