-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Point users to the official documentation when they use n8n --help
#8440
fix(core): Point users to the official documentation when they use n8n --help
#8440
Conversation
n8n --help
n8n --help
n8n --help
n8n --help
n8n --help
n8n --help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I saw in the oclif docs that should be possible. Let me try. |
@krynble it behaves the way you suggested. This got me thinking now though. We're hiding the CLI root help page because
The idea is to send users from The benefit I saw from not maintaining the CLI help in the code was that we only have to maintain the CLI documentation in one place, that is https://docs.n8n.io/hosting/cli-commands/. That benefit would have made up for the UX impairments. But now it seems we have both drawbacks
Maybe we should merge this and create a ticket to bring the root help page back and fix it properly. WDYT? |
1 flaky test on run #3917 ↗︎
Details:
cypress/e2e/5-ndv.cy.ts • 1 flaky test
Review all test suite changes for PR #8440 ↗︎ |
|
✅ All Cypress E2E specs passed |
@despairblue I agree, maybe the action item we can derive from this is revisit the docs page and see if it's up to date. One thing I noticed is that the Could you then create another ticket to check whether our docs page is up to date? |
Will do. Should I assign it to payday or docs? |
That should be Payday @despairblue - You can merge this PR then. |
Got released with |
Summary
The help users got with
n8n --help
was misleading. Some commands had no documentation. If a command had multiple subcommands, only the documentation for the first one would be shown in the main page, e.g.import
would only mention that you can importcredentials
, but not that you can import workflows.An idea here is that we can point the user directly to docs.n8n.io instead.
Downside may be that the docs will always document the latest version, but the user may run an older version of n8n. We're willing to accept that though. And the help for commands and topics would still be available.
This PR has no tests. I don't think it needs one, because the damage that is caused by the custom help message disappearing and the old one appearing again is limited.
If you disagree let me know and I write one, but right now it seams there are no tests that execute
bin/n8n
and check what it prints. So that would a completely new kind of test.cli.help.mp4
Related tickets and issues
https://linear.app/n8n/issue/PAY-195/ensure-n8n-help-gives-useful-and-accurate-info
Review / Merge checklist
(no-changelog)
otherwise. (conventions)