Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gotify does not enable markdown, cannot configure API or provide custom fields #8433

Closed
disconn3ct opened this issue Jan 24, 2024 · 5 comments
Labels

Comments

@disconn3ct
Copy link

Describe the bug
Markdown is listed as enabled here but it does not include the required extras data, nor expose a way to do so. More broadly, gotify expects users to use the extras block for any custom information related to the message but the plugin does not allow it.

To Reproduce
Steps to reproduce the behavior:

  1. Enable gotify and wire it to an instance
  2. Send a message containing markdown, or attempt to set any extras fields (eg extras.client::notification.bigImageUrl)
  3. See unparsed text in the web UI and the android app, no icons, etc.

Expected behavior
It should be possible to pass custom fields to the request. By default, the extras field should enable Markdown as indicated by the docs.

Environment (please complete the following information):

  • OS: [e.g. Ubuntu Linux 22.04]
  • n8n Version [e.g. 1.0.1]
  • Node.js Version [e.g. 18.16.0]
  • Database system [e.g. SQLite; n8n uses SQLite as default otherwise changed]
  • Operation mode [e.g. own; operation modes are own, main and queue. Default is main]

Additional context
https://github.com/n8n-io/n8n/blob/master/packages/nodes-base/nodes/Gotify/Gotify.node.ts#L90 defines the fields, and https://github.com/n8n-io/n8n/blob/master/packages/nodes-base/nodes/Gotify/Gotify.node.ts#L178 uses them.

The default additionalFields should include:

"extras": {
  "client::display": "text/markdown"
}
@Joffcom
Copy link
Member

Joffcom commented Jan 24, 2024

Hey @disconn3ct,

I can't see markdown mentioned on that page but this sounds like a feature request to me and not a bug.

Would you be able to a feature request on the community support forum and we can prioritise adding this based on community feedback.

Alternatively if you want to add this feature you can put in a PR for it.

Let me know if you have any questions on this.

@Joffcom Joffcom closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2024
@disconn3ct
Copy link
Author

Correction. It is listed directly in the node UI.
https://github.com/n8n-io/n8n/blob/master/packages/nodes-base/nodes/Gotify/Gotify.node.ts#L87
This is not a feature request.

@Joffcom
Copy link
Member

Joffcom commented Jan 24, 2024

Hey @disconn3ct,

So it is, In that case I will make sure markdown is working in the morning.

This won't include extra fields it will only fix markdown.

@Joffcom
Copy link
Member

Joffcom commented Jan 25, 2024

Hey @disconn3ct,

I have popped in a PR which will fix the markdown issue, This PR adds a new option that you can set to specify if it is markdown or plain.

@janober
Copy link
Member

janober commented Feb 2, 2024

Fix got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants