fix(editor): Fix workflows filter resetting #8411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
mutdmour
approved these changes
Jan 25, 2024
|
|
|
✅ All Cypress E2E specs passed |
cstuncsik
deleted the
pay-876-filter-by-clicking-on-wf-tag-stops-working-after-resetting
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 26, 2024
* master: fix(editor): Fix workflows filter resetting (#8411) fix(editor): Show pin button on binary output but disable it with tooltip (#8388) fix(Merge Node): Passing on no items to "Input 2" results in wrong output items (#8438) ci: Enforce `noUnusedLocals` on all backend and nodes packages (no-changelog) (#8428) ci: Move docs check notification to #alerts-build (no-changelog) (#8435) 🚀 Release 1.26.0 (#8427)
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On /workflows, tags are no longer clickable (i.e. to apply a filter) after user has reset filters 1x time.
Expected
User can continue to click on a tag to add it to filter criteria, even after they've cleared filters during their session.
Actual
filter-by-tag-bug.mov
Steps or workflow to reproduce (with screenshots/recordings)
n8n version: [cloud prod] [1.9.0]
Open /workflows
Click on a tag
Click "remove filters"
Try clicking on a tag again