feat(Telegram Trigger Node): Verify Webhook requests #8383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Joffcom
approved these changes
Jan 18, 2024
Passing run #3823 ↗︎
Details:
Review all test suite changes for PR #8383 ↗︎ |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
maspio
deleted the
node-1006-telegram-trigger-missing-webhook-verification
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To make sure webhook requests are actually coming from Telegram we can use the secret_token parameter from setWebhook for validation.
Related tickets and issues
NODE-1006
Review / Merge checklist
(no-changelog)otherwise. (conventions)