fix(core): Parse any readable stream response instead of only IncomingMessage #8359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
approved these changes
Jan 17, 2024
1 flaky test on run #3794 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8359 ↗︎
|
✅ All Cypress E2E specs passed |
netroy
deleted the
node-1058-pagination-failing-in-http-request-in-some-cases
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The code was expecting an
IncomingMessageinstance, but it seems it now gets aBrotliDecompressobject from axios. Both extendReadableso, by checking for a Readable stream the issue is fixed.Probably introduced after upgrading axios.Related tickets and issues
#7745
https://linear.app/n8n/issue/NODE-1058/pagination-failing-in-http-request-in-some-cases
Review / Merge checklist