Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nudge users to become template creators if eligible #8357

Merged
merged 11 commits into from
Jan 17, 2024

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Jan 17, 2024

Summary

Add a CTA for users to become template creators. The CTA is shown for users who have at least 3 active workflows with each at least 5 successful production executions.

Kapture.2024-01-17.at.11.17.52.mp4

Related tickets and issues

https://linear.app/n8n/issue/ADO-1669/feature-template-creator-cta-for-existing-users

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 17, 2024
@tomi tomi requested a review from ivov January 17, 2024 12:21
@tomi
Copy link
Contributor Author

tomi commented Jan 17, 2024

@ivov thank you for a thorough review 🙇 Addressed all feedback. Please have another look 🙏

ivov
ivov previously approved these changes Jan 17, 2024
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

getBecomeTemplateCreatorCta().should('not.exist');
});

it('should show the CTA', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('should show the CTA', () => {
it('should show the CTA if the user is eligible', () => {

@@ -98,4 +101,23 @@ export class WorkflowStatisticsRepository extends Repository<WorkflowStatistics>
throw error;
}
}

async queryNumWorkflowsUserHasWith5OrMoreProdExecs(userId: User['id']): Promise<number> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fifty?

Copy link
Contributor Author

@tomi tomi Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to be a bit clearer

Copy link

cypress bot commented Jan 17, 2024

Passing run #3808 ↗︎

0 336 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Project: n8n Commit: 4242cf62d5
Status: Passed Duration: 03:22 💡
Started: Jan 17, 2024 3:46 PM Ended: Jan 17, 2024 3:49 PM

Review all test suite changes for PR #8357 ↗︎

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@tomi tomi requested a review from ivov January 17, 2024 15:31
Copy link
Contributor

✅ All Cypress E2E specs passed

@tomi tomi merged commit 9945701 into master Jan 17, 2024
32 checks passed
@tomi tomi deleted the ado-1669-feature-template-creator-cta-for-existing-users branch January 17, 2024 17:07
@github-actions github-actions bot mentioned this pull request Jan 24, 2024
@janober
Copy link
Member

janober commented Jan 24, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants