Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Ollama Model Node): Use a simpler credentials test #8318

Merged
merged 2 commits into from
Jan 12, 2024
Merged

fix(Ollama Model Node): Use a simpler credentials test #8318

merged 2 commits into from
Jan 12, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jan 12, 2024

Summary

There are two issues with the current credentials test

  1. It assumes that anyone using Ollama has llama2:latest downloaded
  2. It uses a more expensive inference operation just to determine if the service is reachable.

Review / Merge checklist

  • PR title and summary are descriptive

@netroy netroy requested a review from OlegIvaniv January 12, 2024 14:58
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 12, 2024
@cypress Cypress
Copy link

cypress bot commented Jan 12, 2024

Passing run #3740 ↗︎

0 331 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: d24d873d9f
Status: Passed Duration: 03:15 💡
Started: Jan 12, 2024 3:19 PM Ended: Jan 12, 2024 3:22 PM

Review all test suite changes for PR #8318 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 63b738a into master Jan 12, 2024
28 checks passed
@netroy netroy deleted the fix-Ollama-credential-test branch January 12, 2024 15:37
netroy added a commit that referenced this pull request Jan 16, 2024
@netroy
fix(Ollama Model Node): Use a simpler credentials test (#8318)
371d0ae
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Merged
@janober
Copy link
Member

janober commented Jan 16, 2024

Got released with [email protected]

@github-actions github-actions bot mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegIvaniv OlegIvaniv OlegIvaniv approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @OlegIvaniv