feat(editor): Select credentials in template setup if theres only one #7879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
mutdmour
reviewed
Nov 30, 2023
| for (const credUsage of credentialUsages.value) { | ||
| const availableCreds = credentialsStore.getCredentialsByType(credUsage.credentialType); | ||
|
|
||
| if (availableCreds.length === 1) { |
There was a problem hiding this comment.
should we avoid doing this for generic http credentials? I think we have some logic around that for automatically setting creds in NDV
There was a problem hiding this comment.
I couldn't find any sophisticated logic how those would be ignore. I added a simple exclude list for those credential types. Does that work @mutdmour ?
There was a problem hiding this comment.
Yup.. Looks good to me.. Sorry I don't recall specifics of that, but I find it really annoying usually when it auto selects these cred types.
tomi
changed the title
mutdmour
approved these changes
Nov 30, 2023
1 flaky test on run #3139 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Two-factor authentication > Should be able to login with MFA token |
Screenshots
Video
|
|
Review all test suite changes for PR #7879 ↗︎
|
✅ All Cypress E2E specs passed |
tomi
deleted the
feat-select-first-credential-in-template-setup-when-theres-only-one
branch
Merged
ivov
added a commit
that referenced
this pull request
Dec 6, 2023
# [1.20.0](https://github.com/n8n-io/n8n/compare/[email protected]@1.20.0) (2023-12-06) ### Bug Fixes * **AWS DynamoDB Node:** Improve error message parsing ([#7793](#7793)) ([5ba5ed8](5ba5ed8)) * **core:** Allow grace period for binary data deletion after manual execution ([#7889](#7889)) ([61d8aeb](61d8aeb)) * **core:** Consolidate ownership and sharing data on workflows and credentials ([#7920](#7920)) ([38b88b9](38b88b9)) * **core:** Fix hard deletes stopping if database query throws ([#7848](#7848)) ([46dd4d3](46dd4d3)) * **core:** Make sure mfa secret and recovery codes are not returned on login ([#7936](#7936)) ([f5502cc](f5502cc)) * **editor:** Fix deletion of last execution at execution preview ([#7883](#7883)) ([ce2d388](ce2d388)) * **editor:** Replace isInstanceOwner checks with scopes where applicable ([#7858](#7858)) ([132d691](132d691)) * **Google Sheets Node:** Fix issue with paired items not being set correctly ([#7862](#7862)) ([5207a2f](5207a2f)) * **Notion Node:** Fix broken Notion node parameters ([#7864](#7864)) ([51d1f5b](51d1f5b)), closes [#7791](#7791) ### Features * **BambooHR Node:** Add support for Only Current on company reports ([#7878](#7878)) ([4175801](4175801)) * **core:** Allow admin creation ([#7837](#7837)) ([476806e](476806e)) * **editor:** Add sections to create node panel ([#7831](#7831)) ([39fa8d2](39fa8d2)) * **editor:** Open template credential setup from collection ([#7882](#7882)) ([627ddb9](627ddb9)) * **editor:** Select credentials in template setup if theres only one ([#7879](#7879)) ([fe3417a](fe3417a)) ### Performance Improvements * **editor:** Improve node rendering performance when opening large workflows ([#7904](#7904)) ([a8049a0](a8049a0)) * **editor:** Improve performance when opening large workflows with node issues ([#7901](#7901)) ([4bd7ae2](4bd7ae2)) Co-authored-by: ivov <[email protected]>
|
Got released with |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically select credentials in the template credential setup if there's only one available.
NOTE! This feature is still behind a feature flag. To test, set:
Kapture.2023-11-30.at.11.16.22.mp4