Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Replace isInstanceOwner checks with scopes where applicable #7858

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 29, 2023
cstuncsik and others added 10 commits November 29, 2023 11:33
…re-applicable' of github.com:n8n-io/n8n into pay-1068-replace-isinstanceowner-checks-with-scopes-where-applicable
…re-applicable' of github.com:n8n-io/n8n into pay-1068-replace-isinstanceowner-checks-with-scopes-where-applicable
…re-applicable' of github.com:n8n-io/n8n into pay-1068-replace-isinstanceowner-checks-with-scopes-where-applicable
…instanceowner-checks-with-scopes-where-applicable
@cstuncsik cstuncsik marked this pull request as ready for review November 29, 2023 12:24
Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Small changes requested to make sure we keep consistent with permission checks.

@cstuncsik cstuncsik requested a review from alexgrozav November 29, 2023 13:20
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Nov 29, 2023

Passing run #3172 ↗︎

0 297 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project: n8n Commit: 6c190925bc
Status: Passed Duration: 06:16 💡
Started: Dec 4, 2023 8:53 AM Ended: Dec 4, 2023 8:59 AM

Review all test suite changes for PR #7858 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

…instanceowner-checks-with-scopes-where-applicable
…instanceowner-checks-with-scopes-where-applicable
Copy link
Contributor

github-actions bot commented Dec 4, 2023

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 132d691 into master Dec 4, 2023
22 of 31 checks passed
@cstuncsik cstuncsik deleted the pay-1068-replace-isinstanceowner-checks-with-scopes-where-applicable branch December 4, 2023 09:02
@github-actions github-actions bot mentioned this pull request Dec 6, 2023
ivov added a commit that referenced this pull request Dec 6, 2023
#
[1.20.0](https://github.com/n8n-io/n8n/compare/[email protected]@1.20.0)
(2023-12-06)


### Bug Fixes

* **AWS DynamoDB Node:** Improve error message parsing
([#7793](#7793))
([5ba5ed8](5ba5ed8))
* **core:** Allow grace period for binary data deletion after manual
execution ([#7889](#7889))
([61d8aeb](61d8aeb))
* **core:** Consolidate ownership and sharing data on workflows and
credentials ([#7920](#7920))
([38b88b9](38b88b9))
* **core:** Fix hard deletes stopping if database query throws
([#7848](#7848))
([46dd4d3](46dd4d3))
* **core:** Make sure mfa secret and recovery codes are not returned on
login ([#7936](#7936))
([f5502cc](f5502cc))
* **editor:** Fix deletion of last execution at execution preview
([#7883](#7883))
([ce2d388](ce2d388))
* **editor:** Replace isInstanceOwner checks with scopes where
applicable ([#7858](#7858))
([132d691](132d691))
* **Google Sheets Node:** Fix issue with paired items not being set
correctly ([#7862](#7862))
([5207a2f](5207a2f))
* **Notion Node:** Fix broken Notion node parameters
([#7864](#7864))
([51d1f5b](51d1f5b)),
closes [#7791](#7791)


### Features

* **BambooHR Node:** Add support for Only Current on company reports
([#7878](#7878))
([4175801](4175801))
* **core:** Allow admin creation
([#7837](#7837))
([476806e](476806e))
* **editor:** Add sections to create node panel
([#7831](#7831))
([39fa8d2](39fa8d2))
* **editor:** Open template credential setup from collection
([#7882](#7882))
([627ddb9](627ddb9))
* **editor:** Select credentials in template setup if theres only one
([#7879](#7879))
([fe3417a](fe3417a))


### Performance Improvements

* **editor:** Improve node rendering performance when opening large
workflows ([#7904](#7904))
([a8049a0](a8049a0))
* **editor:** Improve performance when opening large workflows with node
issues ([#7901](#7901))
([4bd7ae2](4bd7ae2))

Co-authored-by: ivov <[email protected]>
@janober
Copy link
Member

janober commented Dec 6, 2023

Got released with [email protected]

@github-actions github-actions bot mentioned this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants