Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Disable context menu actions in read-only mode #7789

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Nov 23, 2023

Github issue / Community forum post (link here to close automatically):

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 23, 2023
Copy link
Contributor

@cstuncsik cstuncsik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Nov 23, 2023

2 flaky tests on run #3004 ↗︎

0 282 5 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: 2e5eb527e5
Status: Passed Duration: 05:49 💡
Started: Nov 23, 2023 11:53 AM Ended: Nov 23, 2023 11:59 AM
Flakiness  12-canvas-actions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Canvas Actions > should execute node Screenshots Video
Flakiness  28-resource-mapper.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Resource Mapper > should correctly delete single field Screenshots Video

Review all test suite changes for PR #7789 ↗︎

@elsmr elsmr merged commit 902beff into master Nov 23, 2023
19 of 20 checks passed
@elsmr elsmr deleted the node-948-bug-can-execute-nodes-in-executions-view branch November 23, 2023 16:10
@github-actions github-actions bot mentioned this pull request Nov 29, 2023
ivov added a commit that referenced this pull request Nov 29, 2023
#
[1.19.0](https://github.com/n8n-io/n8n/compare/[email protected]@1.19.0)
(2023-11-29)


### Bug Fixes

* **core:** Ensure member and admin cannot be promoted to owner
([#7830](#7830))
([9b87a59](9b87a59)),
closes
[/linear.app/n8n/issue/PAY-985/add-user-role-modification-endpoint#comment-62355f6](https://github.com//linear.app/n8n/issue/PAY-985/add-user-role-modification-endpoint/issues/comment-62355f6)
* **core:** Prevent error messages due to statistics about data loading
([#7824](#7824))
([847f6ac](847f6ac))
* **core:** Tighten checks for multi-main setup usage
([#7788](#7788))
([fdb2c18](fdb2c18))
* **core:** Use AbortController to notify nodes to abort execution
([#6141](#6141))
([d2c18c5](d2c18c5))
* **editor:** Add telemetry to workflow history
([#7811](#7811))
([d497041](d497041))
* **editor:** Allow owners and admins to share workflows and credentials
they don't own ([#7833](#7833))
([3ab3ec9](3ab3ec9))
* **editor:** Disable context menu actions in read-only mode
([#7789](#7789))
([902beff](902beff))
* **editor:** Fix cloud plan data loading on instance
([#7841](#7841))
([8b99384](8b99384))
* **editor:** Fix credential icon for old node type version
([#7843](#7843))
([4074107](4074107))
* **editor:** Fix icon for unknown node type
([#7842](#7842))
([28ac5a7](28ac5a7))
* **editor:** Fix mouse position in workflow previews
([#7853](#7853))
([c063398](c063398))
* **editor:** Show nice error when environment is not set up
([#7778](#7778))
([5835e05](5835e05))
* **editor:** Suppress dev server websocket messages in workflow view
([#7808](#7808))
([685ffd7](685ffd7))
* **Google Sheets Node:** Read operation execute for each item
([#7800](#7800))
([d548872](d548872))
* **HTTP Request Node:** Enable expressions for binary input data fields
([#7782](#7782))
([6208af0](6208af0))
* **Microsoft SQL Node:** Prevent double escaping table name
([#7801](#7801))
([73ec753](73ec753))


### Features

* Add AI tool building capabilities
([#7336](#7336))
([87def60](87def60))
* Add initial scope checks via decorators
([#7737](#7737))
([a37f1cb](a37f1cb))
* Ado 1296 spike credential setup in templates
([#7786](#7786))
([aae45b0](aae45b0))
* **core:** Add Support for custom CORS origins for webhooks
([#7455](#7455))
([99a9ea4](99a9ea4))
* **core:** Allow user role modification
([#7797](#7797))
([7a86d36](7a86d36))
* **core:** Set up endpoint for all existing roles with license flag
([#7834](#7834))
([2356fb0](2356fb0))
* **editor:** Add node name and version to NDV node settings
([#7731](#7731))
([da85198](da85198))
* **editor:** Add routing middleware, permission checks, RBAC store,
RBAC component ([#7702](#7702))
([67a8891](67a8891))
* **editor:** Replace middleware for Role checks with Scope checks
([#7847](#7847))
([72852a6](72852a6))
* **editor:** Show avatars for users currently working on the same
workflow ([#7763](#7763))
([77bc8ec](77bc8ec))
* **Notion Node:** Option to simplify output in getChildBlocks operation
([#7791](#7791))
([d667bca](d667bca))
* **Slack Node:** Add support for getting the profile of a user
([#7829](#7829))
([90bb6ba](90bb6ba))

Co-authored-by: ivov <[email protected]>
netroy pushed a commit that referenced this pull request Nov 29, 2023
Github issue / Community forum post (link here to close automatically):
@github-actions github-actions bot mentioned this pull request Nov 29, 2023
netroy added a commit that referenced this pull request Nov 30, 2023
## [1.18.1](https://github.com/n8n-io/n8n/compare/[email protected]@1.18.1)
(2023-11-30)


### Bug Fixes

* **AWS DynamoDB Node:** Improve error message parsing
([#7793](#7793))
([192770a](192770a))
* **core:** Prevent error messages due to statistics about data loading
([#7824](#7824))
([c7d600a](c7d600a))
* **core:** Tighten checks for multi-main setup usage
([#7788](#7788))
([060987a](060987a))
* **core:** Use AbortController to notify nodes to abort execution
([#6141](#6141))
([dbad88d](dbad88d))
* **editor:** Disable context menu actions in read-only mode
([#7789](#7789))
([ae25503](ae25503))
* **editor:** Fix cloud plan data loading on instance
([#7841](#7841))
([b0039a3](b0039a3))
* **editor:** Fix credential icon for old node type version
([#7843](#7843))
([9b0e2d1](9b0e2d1))
* **editor:** Fix icon for unknown node type
([#7842](#7842))
([9cd0a75](9cd0a75))
* **editor:** Fix mouse position in workflow previews
([#7853](#7853))
([83b5e6a](83b5e6a))
* **editor:** Suppress dev server websocket messages in workflow view
([#7808](#7808))
([8a71178](8a71178))
* **Google Sheets Node:** Fix issue with paired items not being set
correctly ([#7862](#7862))
([95854db](95854db))
* **Google Sheets Node:** Read operation execute for each item
([#7800](#7800))
([2563433](2563433))
* **HTTP Request Node:** Enable expressions for binary input data fields
([#7782](#7782))
([7ec748a](7ec748a))
* **Microsoft SQL Node:** Prevent double escaping table name
([#7801](#7801))
([6a8e7b1](6a8e7b1))
* **Notion Node:** Fix broken Notion node parameters
([#7864](#7864))
([940944e](940944e))

Co-authored-by: netroy <[email protected]>
@janober
Copy link
Member

janober commented Nov 30, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants