Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix design system button with icon vertical alignment #6284

Merged
merged 4 commits into from
May 24, 2023

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/design-system/**/*.vue:

  • Used design system tokens (colors, spacings...) where possible.
  • Updated Storybook with new component or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5d2f474) 27.65% compared to head (8d2cb6c) 27.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6284   +/-   ##
=======================================
  Coverage   27.65%   27.65%           
=======================================
  Files        2957     2957           
  Lines      181306   181307    +1     
  Branches    19723    19724    +1     
=======================================
+ Hits        50132    50133    +1     
  Misses     130427   130427           
  Partials      747      747           
Impacted Files Coverage Δ
.../design-system/src/components/N8nButton/Button.vue 98.15% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cstuncsik cstuncsik requested a review from alexgrozav May 22, 2023 12:00
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik requested a review from alexgrozav May 23, 2023 13:54
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit fc580f7 into master May 24, 2023
@cstuncsik cstuncsik deleted the pay-450-fix-design-system-button-with-icon branch May 24, 2023 11:03
@janober
Copy link
Member

janober commented May 25, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants