Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Execution Data Node): New node #6247

Merged
merged 7 commits into from
May 24, 2023

Conversation

michael-radency
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@michael-radency michael-radency added node/new Creation of an entirely new node n8n team Authored by the n8n team labels May 15, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Files matching packages/nodes-base/package.json:

  • Avoided adding dependencies for nodes if not absolutely necessary.

Make sure to check off this list before asking for review.

{
// eslint-disable-next-line n8n-nodes-base/node-param-display-name-miscased
name: 'Save execution data for search',
value: 'saveData',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that not be more "save" rather than "saveData"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, saveData too verbose

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (e046f65) 27.65% compared to head (80dc886) 27.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6247      +/-   ##
==========================================
- Coverage   27.65%   27.64%   -0.01%     
==========================================
  Files        2957     2958       +1     
  Lines      181306   181320      +14     
  Branches    19724    19726       +2     
==========================================
  Hits        50132    50132              
- Misses     130427   130441      +14     
  Partials      747      747              
Impacted Files Coverage Δ
...des-base/nodes/ExecutionData/ExecutionData.node.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 3f7c4f0 into master May 24, 2023
@michael-radency michael-radency deleted the node-517-execution-data-node-new-node branch May 24, 2023 11:00
@janober
Copy link
Member

janober commented May 25, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/new Creation of an entirely new node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants