-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Execution Data Node): New node #6247
feat(Execution Data Node): New node #6247
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
{ | ||
// eslint-disable-next-line n8n-nodes-base/node-param-display-name-miscased | ||
name: 'Save execution data for search', | ||
value: 'saveData', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that not be more "save" rather than "saveData"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, saveData too verbose
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6247 +/- ##
==========================================
- Coverage 27.65% 27.64% -0.01%
==========================================
Files 2957 2958 +1
Lines 181306 181320 +14
Branches 19724 19726 +2
==========================================
Hits 50132 50132
- Misses 130427 130441 +14
Partials 747 747
☔ View full report in Codecov by Sentry. |
…execution-data-node-new-node
…b.com/n8n-io/n8n into node-517-execution-data-node-new-node
✅ All Cypress E2E specs passed |
Got released with |
Github issue / Community forum post (link here to close automatically):