fix(editor): Fix Show details summary
#6113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
netroy
reviewed
Apr 27, 2023
| @@ -5,8 +5,20 @@ import xss, { friendlyAttrValue } from 'xss'; | |||
| */ | |||
|
|
|||
| export function sanitizeHtml(dirtyHtml: string) { | |||
| const allowedAttributes = ['href', 'name', 'target', 'title', 'class', 'id']; | |||
| const allowedTags = ['p', 'strong', 'b', 'code', 'a', 'br', 'i', 'em', 'small']; | |||
| const allowedAttributes = ['href', 'name', 'target', 'title', 'class', 'id', 'style']; | |||
There was a problem hiding this comment.
can we move these out of the function body, so that these are reused and we aren't creating extra work for the GC.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6113 +/- ##
==========================================
+ Coverage 19.11% 19.20% +0.09%
==========================================
Files 2588 2589 +1
Lines 116755 116903 +148
Branches 18336 18339 +3
==========================================
+ Hits 22314 22455 +141
- Misses 93802 93803 +1
- Partials 639 645 +6
☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
n8n team
|
|
netroy
approved these changes
Apr 28, 2023
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
May 2, 2023
* master: (37 commits) fix(editor): Fix copy selection behavior (#6112) fix(core): Account for nodes with renamable content (#6109) fix(editor): Fix quote handling on dollar-sign variable completions (#6128) fix(editor): Fix cropped off completions docstrings (#6129) fix(Date & Time Node): Numbers conversions fix fix(Merge Node): Do not error if expected key is missing fix(core): Improve saml endpoints and audit events (#6107) fix: Prevent displaying an endless timer in the execution list for finished executions (#6137) fix(editor): Fix `Show details` summary (#6113) fix(editor): Fix sidebar button styling (#6138) fix(editor): Fix unique names for node duplication (#6134) fix(editor): Fix missing `Stop Listening` button (#6125) fix(editor): Fix unscrollable node settings (#6133) fix(core): Avoid using `Object.keys` on Buffer and other non-plain objects (#6131) fix(editor): Change execution list tab loader design (#6120) fix(Slack Node): Restore ability to send text in addition of blocks or attachments feat(editor): Add support for `loadOptionsDependsOn` to RLC (#6101) fix: Correctly allow sharees to test credential when opening the modal (#6111) fix(core): Fix `hasOwnProperty` on augmented objects (#6124) fix(core): Only take into account users that active for the first time to show activation modal (no-changelog) (#6121) ...
MiloradFilipovic
added a commit
that referenced
this pull request
May 2, 2023
…rce-mapper-ui-P2 * feature/resource-mapping-component: (37 commits) fix(editor): Fix copy selection behavior (#6112) fix(core): Account for nodes with renamable content (#6109) fix(editor): Fix quote handling on dollar-sign variable completions (#6128) fix(editor): Fix cropped off completions docstrings (#6129) fix(Date & Time Node): Numbers conversions fix fix(Merge Node): Do not error if expected key is missing fix(core): Improve saml endpoints and audit events (#6107) fix: Prevent displaying an endless timer in the execution list for finished executions (#6137) fix(editor): Fix `Show details` summary (#6113) fix(editor): Fix sidebar button styling (#6138) fix(editor): Fix unique names for node duplication (#6134) fix(editor): Fix missing `Stop Listening` button (#6125) fix(editor): Fix unscrollable node settings (#6133) fix(core): Avoid using `Object.keys` on Buffer and other non-plain objects (#6131) fix(editor): Change execution list tab loader design (#6120) fix(Slack Node): Restore ability to send text in addition of blocks or attachments feat(editor): Add support for `loadOptionsDependsOn` to RLC (#6101) fix: Correctly allow sharees to test credential when opening the modal (#6111) fix(core): Fix `hasOwnProperty` on augmented objects (#6124) fix(core): Only take into account users that active for the first time to show activation modal (no-changelog) (#6121) ...
netroy
pushed a commit
that referenced
this pull request
May 2, 2023
* 🐛 Fix `Show details` summary * 🚚 Move constants out of sanitizer
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/n8n/issue/ADO-367/bug-error-not-clickable-cannot-expand-it