Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Skip SAML onboarding for users with first- and lastname #5966

Merged

Conversation

flipswitchingmonkey
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@flipswitchingmonkey flipswitchingmonkey marked this pull request as ready for review April 13, 2023 07:45
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (303521a) 17.91% compared to head (7358b7b) 17.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5966   +/-   ##
=======================================
  Coverage   17.91%   17.92%           
=======================================
  Files        2539     2539           
  Lines      115275   115279    +4     
  Branches    17964    17966    +2     
=======================================
+ Hits        20657    20660    +3     
- Misses      93991    93992    +1     
  Partials      627      627           
Impacted Files Coverage Δ
...ages/cli/src/sso/saml/routes/saml.controller.ee.ts 39.34% <ø> (ø)
packages/cli/src/sso/saml/saml.service.ee.ts 29.67% <0.00%> (-0.20%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Apr 13, 2023
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@flipswitchingmonkey flipswitchingmonkey merged commit 8474cd3 into master Apr 13, 2023
@flipswitchingmonkey flipswitchingmonkey deleted the pay-351-onboarding-is-required-always-even-when branch April 13, 2023 08:09
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants