fix(core): augmentObject should use existing property descriptors whenever possible
#5872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
core
netroy
changed the title
augmentObject should use existing property descriptors whenever possible
netroy
force-pushed
the
fix-ownKeys-non-enumerable-props
branch
from
0d21f85 to
7fffe8f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5872 +/- ##
=======================================
Coverage 15.05% 15.06%
=======================================
Files 2476 2476
Lines 113462 113465 +3
Branches 17744 17746 +2
=======================================
+ Hits 17087 17090 +3
Misses 95793 95793
Partials 582 582
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
flipswitchingmonkey
previously approved these changes
Mar 31, 2023
netroy
force-pushed
the
fix-ownKeys-non-enumerable-props
branch
from
7fffe8f to
2c01187
Compare
flipswitchingmonkey
approved these changes
Apr 3, 2023
netroy
added a commit
that referenced
this pull request
Apr 3, 2023
…henever possible (#5872) * fix(core): Augmented objects should use existing property descriptors whenever possible * add a test for non-enumerable keys
believe-Mahesh
pushed a commit
to believe-Mahesh/n8n
that referenced
this pull request
Apr 4, 2023
…henever possible (n8n-io#5872) * fix(core): Augmented objects should use existing property descriptors whenever possible * add a test for non-enumerable keys
netroy
added a commit
that referenced
this pull request
Apr 4, 2023
…henever possible (#5872) * fix(core): Augmented objects should use existing property descriptors whenever possible * add a test for non-enumerable keys
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 4, 2023
* master: (87 commits) ci: Always run e2e tests on PR approval (no-changelog) (#5900) fix(core): Improve axios error handling in nodes (#5891) fix(HTTP Request Node): Detect mime-type from streaming responses (#5896) fix(Compare Datasets Node): Fuzzy compare not comparing keys missing in one of inputs fix(core): `augmentObject` should use existing property descriptors whenever possible (#5872) fix(core): Prevent augmentObject from creating infinitely deep proxies (#5893) feat(Postgres Node): Overhaul node fix: Add optional chaining for 'isArtificalRecoveredEventItem' (no-changelog) (#5860) fix(core): Use table-prefixes in queries in import commands (#5887) fix(AWS SNS Node): Fix an issue with messages failing to send if they contain certain characters (#5807) fix(core): Fix the issue of nodes not loading when run via npx (#5888) fix(Gmail Node): Gmail luxon object support, fix for timestamp test(editor): Fix failing licensing related e2e specs (no-changelog) (#5884) fix: Upgrade versions in pnpm-lock.yaml (no-changelog) Revert "fix(core): Improve axios error handling in nodes (#5699)" fix(editor): Update execution loading parameters after pushing test values (no-changelog) (#5876) ci: Fix catch clause lint rule (#5875) fix(editor): Fix loading executions in long execution list (#5843) fix(HTTP Request Node): Support for dot notation in JSON body feat(SSH Node): Hide the private key within the ssh credential (#5871) ... # Conflicts: # packages/nodes-base/credentials/Postgres.credentials.ts # packages/nodes-base/nodes/Postgres/Postgres.node.ts # packages/nodes-base/nodes/Postgres/test/v2/utils.test.ts # packages/nodes-base/nodes/Postgres/v2/PostgresV2.node.ts # packages/nodes-base/nodes/Postgres/v2/actions/common.descriptions.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/deleteTable.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/executeQuery.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/insert.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/select.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/update.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/upsert.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/versionDescription.ts # packages/nodes-base/nodes/Postgres/v2/helpers/interfaces.ts # packages/nodes-base/nodes/Postgres/v2/helpers/utils.ts # packages/nodes-base/nodes/Postgres/v2/methods/index.ts # packages/nodes-base/nodes/Postgres/v2/transport/index.ts
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 4, 2023
…rce-mapper-ui * feature/resource-mapping-component: (87 commits) ci: Always run e2e tests on PR approval (no-changelog) (#5900) fix(core): Improve axios error handling in nodes (#5891) fix(HTTP Request Node): Detect mime-type from streaming responses (#5896) fix(Compare Datasets Node): Fuzzy compare not comparing keys missing in one of inputs fix(core): `augmentObject` should use existing property descriptors whenever possible (#5872) fix(core): Prevent augmentObject from creating infinitely deep proxies (#5893) feat(Postgres Node): Overhaul node fix: Add optional chaining for 'isArtificalRecoveredEventItem' (no-changelog) (#5860) fix(core): Use table-prefixes in queries in import commands (#5887) fix(AWS SNS Node): Fix an issue with messages failing to send if they contain certain characters (#5807) fix(core): Fix the issue of nodes not loading when run via npx (#5888) fix(Gmail Node): Gmail luxon object support, fix for timestamp test(editor): Fix failing licensing related e2e specs (no-changelog) (#5884) fix: Upgrade versions in pnpm-lock.yaml (no-changelog) Revert "fix(core): Improve axios error handling in nodes (#5699)" fix(editor): Update execution loading parameters after pushing test values (no-changelog) (#5876) ci: Fix catch clause lint rule (#5875) fix(editor): Fix loading executions in long execution list (#5843) fix(HTTP Request Node): Support for dot notation in JSON body feat(SSH Node): Hide the private key within the ssh credential (#5871) ... # Conflicts: # packages/editor-ui/src/constants.ts # pnpm-lock.yaml
|
Got released with |
1 similar comment
|
Got released with |
sunilrr
pushed a commit
to fl-g6/qp-n8n
that referenced
this pull request
Apr 24, 2023
…henever possible (n8n-io#5872) * fix(core): Augmented objects should use existing property descriptors whenever possible * add a test for non-enumerable keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5847