feat(editor): Enable saving workflow when node details view is open #5856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
OlegIvaniv
requested changes
Mar 31, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5856 +/- ##
=======================================
Coverage 15.02% 15.02%
=======================================
Files 2476 2476
Lines 113411 113429 +18
Branches 17737 17739 +2
=======================================
+ Hits 17036 17046 +10
- Misses 95796 95801 +5
- Partials 579 582 +3 see 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
OlegIvaniv
approved these changes
Mar 31, 2023
n8n-assistant
bot
added
the
Upcoming Release
believe-Mahesh
pushed a commit
to believe-Mahesh/n8n
that referenced
this pull request
Apr 4, 2023
…8n-io#5856) * feat(editor): Enable saving workflow when node details view is open * ⚡ Preventing event propagation * ⚡ Move save event handler to `NodeDetailsView` * ✅ Added e2e tests * 👕 Fixing linting and removing unnecessary event logic --------- Co-authored-by: Oleg Ivaniv <[email protected]>
|
Got released with |
sunilrr
pushed a commit
to fl-g6/qp-n8n
that referenced
this pull request
Apr 24, 2023
…8n-io#5856) * feat(editor): Enable saving workflow when node details view is open * ⚡ Preventing event propagation * ⚡ Move save event handler to `NodeDetailsView` * ✅ Added e2e tests * 👕 Fixing linting and removing unnecessary event logic --------- Co-authored-by: Oleg Ivaniv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one should enable saving current workflow from NDV. Please mind that saving cannot be performed while editable text inputs are focused, so this popup message should indicate when wf is saved successfully:
Fixes ADO-511