Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Fix mapping with special characters #5837

Merged
merged 8 commits into from
Mar 30, 2023
Merged

fix(editor): Fix mapping with special characters #5837

merged 8 commits into from
Mar 30, 2023

Conversation

mutdmour
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2023 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 30, 2023
@mutdmour mutdmour marked this pull request as ready for review March 30, 2023 11:02
cstuncsik
cstuncsik previously approved these changes Mar 30, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (6f72091) 14.83% compared to head (2f6554c) 14.83%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5837      +/-   ##
==========================================
- Coverage   14.83%   14.83%   -0.01%     
==========================================
  Files        2475     2475              
  Lines      113367   113397      +30     
  Branches    17702    17735      +33     
==========================================
- Hits        16823    16818       -5     
- Misses      95999    96006       +7     
- Partials      545      573      +28
Impacted Files Coverage Δ
packages/editor-ui/src/utils/mappingUtils.ts 97.22% <100.00%> (+0.12%) ⬆️

... and 62 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mutdmour mutdmour changed the title fix: Fix mapping with special characters fix(editor): Fix mapping with special characters Mar 30, 2023
cstuncsik
cstuncsik previously approved these changes Mar 30, 2023
View reviewed changes
@cypress
Copy link

cypress bot commented Mar 30, 2023

Passing run #306 ↗︎

0 183 0 0 Flakiness 0

Details:

🌳 ado-295 🖥️ base:16.18.1 🤖 mutasem 🗃️ e2e/*
Project: n8n Commit: 2f6554c0b7
Status: Passed Duration: 06:36 💡
Started: Mar 30, 2023 1:30 PM Ended: Mar 30, 2023 1:36 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mutdmour mutdmour merged commit f8f584c into master Mar 30, 2023
@mutdmour mutdmour deleted the ado-295 branch March 30, 2023 13:50
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 30, 2023
believe-Mahesh pushed a commit to believe-Mahesh/n8n that referenced this pull request Apr 4, 2023
@mutdmour @believe-Mahesh
fix(editor): Fix mapping with special characters (n8n-io#5837)
90af8b8 
* fix: Fix mapping with special characters

* refactor: rename var

* test: update more unit tests

* test: update mapping test

* test: update mapping test
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@mutdmour @sunilrr
fix(editor): Fix mapping with special characters (n8n-io#5837)
ea5b735 
* fix: Fix mapping with special characters

* refactor: rename var

* test: update more unit tests

* test: update mapping test

* test: update mapping test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstuncsik cstuncsik cstuncsik approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released skip-e2e ui Enhancement in /editor-ui or /design-system Upcoming Release Will be part of the upcoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutdmour @janober @cstuncsik