fix(core): Do not user util.types.isProxy for tracking of augmented objects
#5836
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
| ) | ||
| return value; | ||
|
|
||
| // Track augmented objects to prevent infinite recursion in cases where an object contains circular references | ||
| augmentedObjects.add(value); |
There was a problem hiding this comment.
this will hold on references to these objects forever, and lead to a memory-leak.
There was a problem hiding this comment.
nevermind. I forgot that WeakSet would not block the GC.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5836 +/- ##
=======================================
Coverage 14.83% 14.84%
=======================================
Files 2475 2475
Lines 113367 113368 +1
Branches 17702 17703 +1
=======================================
+ Hits 16823 16824 +1
Misses 95999 95999
Partials 545 545
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
This PR updates the
augmentfunction inutils.tsto use aWeakSetto track objects that have already been augmented. This prevents infinite recursion in cases where an object contains circular references.Previously, the
augmentfunction used theisProxyfunction from theutilmodule to check if an object had already been augmented. However, this caused issues when running in browser environment where theutilmodule was not available.Github issue / Community forum post (link here to close automatically): #5769