Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Handle Date and RegExp correctly in jsonStringify #5812

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Mar 29, 2023

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 29, 2023
@netroy netroy force-pushed the fix-jsonStringify-dates branch from b370ce0 to 194e002 Compare March 29, 2023 18:22
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (522c790) 14.84% compared to head (f5e8606) 14.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5812      +/-   ##
==========================================
- Coverage   14.84%   14.83%   -0.01%     
==========================================
  Files        2475     2475              
  Lines      113366   113366              
  Branches    17690    17691       +1     
==========================================
- Hits        16827    16821       -6     
- Misses      96001    96007       +6     
  Partials      538      538              
Impacted Files Coverage Δ
packages/workflow/src/utils.ts 68.42% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netroy netroy merged commit 4f91525 into master Mar 29, 2023
@netroy netroy deleted the fix-jsonStringify-dates branch March 29, 2023 19:10
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 29, 2023
believe-Mahesh pushed a commit to believe-Mahesh/n8n that referenced this pull request Apr 4, 2023
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released skip-e2e Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants