Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Read ephemeral license from environment and clean up ee flags #5808

Merged
merged 9 commits into from
Mar 31, 2023

Conversation

flipswitchingmonkey
Copy link
Contributor

No description provided.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 29, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

csuermann
csuermann previously approved these changes Mar 29, 2023
…lags

* remove enterprise feature schema for license.cert

* bump license sdk version

* Update packages/cli/package.json

Co-authored-by: Cornelius Suermann <[email protected]>
@netroy netroy force-pushed the fix-license-sdk-refactor branch from 92dc8dd to 6b5d91e Compare March 29, 2023 17:55
@netroy netroy changed the title fix(core): Rename TLicenseContainerStr to TLicenseBlock feat(core): Read ephemeral license from environment and clean up ee flags Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.01 ⚠️

Comparison is base (6c35518) 14.99% compared to head (3280daa) 14.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5808      +/-   ##
==========================================
- Coverage   14.99%   14.99%   -0.01%     
==========================================
  Files        2476     2476              
  Lines      113402   113405       +3     
  Branches    17738    17741       +3     
==========================================
- Hits        17004    17000       -4     
- Misses      95820    95828       +8     
+ Partials      578      577       -1     
Impacted Files Coverage Δ
packages/cli/src/Ldap/constants.ts 100.00% <ø> (ø)
packages/cli/src/License.ts 67.10% <0.00%> (-6.51%) ⬇️
packages/cli/src/Server.ts 0.00% <ø> (ø)
packages/cli/src/api/e2e.api.ts 0.00% <0.00%> (ø)
packages/cli/src/config/index.ts 38.23% <ø> (+2.12%) ⬆️
packages/cli/src/config/schema.ts 37.50% <ø> (ø)
packages/cli/src/executions/executionHelpers.ts 0.00% <0.00%> (ø)
packages/cli/src/sso/saml/constants.ts 100.00% <ø> (ø)
packages/cli/src/Ldap/helpers.ts 82.58% <100.00%> (ø)
...ges/cli/src/UserManagement/UserManagementHelper.ts 78.94% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netroy netroy merged commit 83aef17 into master Mar 31, 2023
@netroy netroy deleted the fix-license-sdk-refactor branch March 31, 2023 11:51
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 31, 2023
believe-Mahesh pushed a commit to believe-Mahesh/n8n that referenced this pull request Apr 4, 2023
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released skip-e2e Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants