Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Convert eventBus controller to decorator style and improve permissions #5779

Merged
merged 9 commits into from
Mar 27, 2023

Conversation

flipswitchingmonkey
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@flipswitchingmonkey flipswitchingmonkey marked this pull request as ready for review March 24, 2023 15:45
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 24, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 24.07% and project coverage change: -0.02 ⚠️

Comparison is base (dd20127) 14.76% compared to head (6706cdb) 14.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5779      +/-   ##
==========================================
- Coverage   14.76%   14.75%   -0.02%     
==========================================
  Files        2474     2475       +1     
  Lines      113342   113355      +13     
  Branches    17685    17698      +13     
==========================================
- Hits        16733    16720      -13     
- Misses      96075    96094      +19     
- Partials      534      541       +7     
Impacted Files Coverage Δ
packages/cli/src/Server.ts 0.00% <0.00%> (ø)
...ages/cli/src/eventbus/EventMessageClasses/index.ts 100.00% <ø> (ø)
...li/src/eventbus/MessageEventBus/MessageEventBus.ts 52.46% <0.00%> (-6.16%) ⬇️
packages/cli/src/eventbus/eventBus.controller.ts 43.11% <33.33%> (ø)
packages/cli/src/middlewares/isOwner.ts 50.00% <50.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

packages/cli/src/eventbus/eventBus.controller.ts Outdated Show resolved Hide resolved
packages/cli/src/eventbus/eventBus.controller.ts Outdated Show resolved Hide resolved
packages/cli/src/eventbus/eventBus.controller.ts Outdated Show resolved Hide resolved
packages/cli/src/eventbus/eventBus.controller.ts Outdated Show resolved Hide resolved
packages/cli/src/eventbus/eventBus.controller.ts Outdated Show resolved Hide resolved
packages/cli/src/eventbus/eventBus.controller.ts Outdated Show resolved Hide resolved
packages/cli/src/eventbus/eventBus.controller.ts Outdated Show resolved Hide resolved
packages/cli/src/eventbus/eventBus.controller.ts Outdated Show resolved Hide resolved
packages/cli/src/eventbus/eventBus.controller.ts Outdated Show resolved Hide resolved
netroy
netroy previously approved these changes Mar 24, 2023
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose a few more changes in this commit. but please free to cherry-pick or not.

let result: FailedEventSummary[] = [];
let amount = 5;
try {
amount = parseInt(req.query?.amount as string);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since req.query will always be an object, this line will never throw. instead you'd end up with amount = NaN for invalid values of amount

# Conflicts:
#	packages/cli/test/integration/shared/utils.ts
@netroy netroy merged commit f15f4bd into master Mar 27, 2023
@netroy netroy deleted the pay-320-make-eventbus-logs-endpoint-only branch March 27, 2023 10:30
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 27, 2023
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants