-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Convert eventBus controller to decorator style and improve permissions #5779
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5779 +/- ##
==========================================
- Coverage 14.76% 14.75% -0.02%
==========================================
Files 2474 2475 +1
Lines 113342 113355 +13
Branches 17685 17698 +13
==========================================
- Hits 16733 16720 -13
- Misses 96075 96094 +19
- Partials 534 541 +7
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose a few more changes in this commit. but please free to cherry-pick or not.
let result: FailedEventSummary[] = []; | ||
let amount = 5; | ||
try { | ||
amount = parseInt(req.query?.amount as string); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since req.query
will always be an object, this line will never throw. instead you'd end up with amount
= NaN
for invalid values of amount
# Conflicts: # packages/cli/test/integration/shared/utils.ts
Got released with |
Github issue / Community forum post (link here to close automatically):