Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Improve ldap/saml toggle and tests #5771

Merged

Conversation

flipswitchingmonkey
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 51.35% and project coverage change: +0.10 🎉

Comparison is base (970c124) 14.65% compared to head (27e9a98) 14.75%.

❗ Current head 27e9a98 differs from pull request most recent head 81e6dda. Consider uploading reports for the commit 81e6dda to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5771      +/-   ##
==========================================
+ Coverage   14.65%   14.75%   +0.10%     
==========================================
  Files        2474     2474              
  Lines      113366   113342      -24     
  Branches    17684    17685       +1     
==========================================
+ Hits        16610    16727     +117     
+ Misses      96231    96081     -150     
- Partials      525      534       +9     
Impacted Files Coverage Δ
packages/cli/src/CredentialsHelper.ts 25.24% <ø> (ø)
packages/cli/src/commands/start.ts 0.00% <0.00%> (ø)
packages/cli/src/LoadNodesAndCredentials.ts 11.94% <6.45%> (+3.03%) ⬆️
packages/cli/src/controllers/nodes.controller.ts 69.91% <25.00%> (-1.26%) ⬇️
packages/cli/src/controllers/auth.controller.ts 76.92% <80.00%> (+1.28%) ⬆️
packages/cli/src/Ldap/helpers.ts 82.58% <86.66%> (-0.26%) ⬇️
packages/cli/src/constants.ts 100.00% <100.00%> (ø)
packages/cli/src/sso/saml/samlHelpers.ts 38.14% <100.00%> (+4.81%) ⬆️
packages/cli/src/sso/ssoHelpers.ts 88.23% <100.00%> (+3.61%) ⬆️

... and 18 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 24, 2023
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flipswitchingmonkey can you check my question here? If it doesn't apply let me know

packages/cli/src/controllers/auth.controller.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flipswitchingmonkey flipswitchingmonkey merged commit 47ee357 into master Mar 24, 2023
@flipswitchingmonkey flipswitchingmonkey deleted the pay-318-integrate-ldap-with-autenticationmethod branch March 24, 2023 16:46
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 24, 2023
@janober
Copy link
Member

janober commented Mar 30, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
* improve ldap/saml toggle and tests

* import cleanup

* reject regular login users when saml is enabled

* lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants