-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Improve ldap/saml toggle and tests #5771
feat(core): Improve ldap/saml toggle and tests #5771
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5771 +/- ##
==========================================
+ Coverage 14.65% 14.75% +0.10%
==========================================
Files 2474 2474
Lines 113366 113342 -24
Branches 17684 17685 +1
==========================================
+ Hits 16610 16727 +117
+ Misses 96231 96081 -150
- Partials 525 534 +9
... and 18 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flipswitchingmonkey can you check my question here? If it doesn't apply let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Got released with |
* improve ldap/saml toggle and tests * import cleanup * reject regular login users when saml is enabled * lint fix
No description provided.