Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LinkedIn Node): Update the version of the API #5720

Merged
merged 5 commits into from
Mar 31, 2023

Conversation

agobrech
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@agobrech agobrech changed the title fix(Node LinkedIn): Update the version of the API fix(LinkedIn Node): Update the version of the API Mar 17, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.76 🎉

Comparison is base (341bfb8) 13.26% compared to head (98c8dae) 15.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5720      +/-   ##
==========================================
+ Coverage   13.26%   15.02%   +1.76%     
==========================================
  Files        2465     2476      +11     
  Lines      112856   113441     +585     
  Branches    17553    17743     +190     
==========================================
+ Hits        14966    17042    +2076     
+ Misses      97380    95818    -1562     
- Partials      510      581      +71     
Impacted Files Coverage Δ
...ages/cli/src/sso/saml/routes/saml.controller.ee.ts 38.98% <ø> (+14.84%) ⬆️
...ages/nodes-base/nodes/LinkedIn/GenericFunctions.ts 0.00% <0.00%> (ø)
...ackages/nodes-base/nodes/LinkedIn/LinkedIn.node.ts 0.00% <0.00%> (ø)

... and 169 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maspio maspio marked this pull request as ready for review March 31, 2023 12:47
@agobrech agobrech merged commit 18d2e7c into master Mar 31, 2023
@agobrech agobrech deleted the node-322-linkedin-api-changes branch March 31, 2023 13:04
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 31, 2023
believe-Mahesh pushed a commit to believe-Mahesh/n8n that referenced this pull request Apr 4, 2023
* 🐛 Change request to follow new API version

* Extract urn from response header

* Change body params for image and media request

* Fix body for Image and Article posts

* remove console log

---------

Co-authored-by: Marcus <[email protected]>
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
* 🐛 Change request to follow new API version

* Extract urn from response header

* Change body params for image and media request

* Fix body for Image and Article posts

* remove console log

---------

Co-authored-by: Marcus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants