fix(core): Improve axios error handling in nodes #5699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
core
This was referenced Mar 16, 2023
netroy
force-pushed
the
n8n-6238-fix-error-handling-in-axios-when-dealing
branch
from
a0956fa to
9364668
Compare
netroy
previously approved these changes
Mar 17, 2023
netroy
force-pushed
the
n8n-6238-fix-error-handling-in-axios-when-dealing
branch
from
9364668 to
8509d38
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5699 +/- ##
==========================================
- Coverage 13.02% 13.02% -0.01%
==========================================
Files 2464 2464
Lines 112844 112836 -8
Branches 17554 17552 -2
==========================================
- Hits 14696 14693 -3
+ Misses 97647 97643 -4
+ Partials 501 500 -1
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
netroy
approved these changes
Mar 20, 2023
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
|
Got reverted as it change the response for errors which caused multiple issues. |
netroy
added a commit
that referenced
this pull request
Apr 3, 2023
…)"" This reverts commit aed5674.
netroy
added a commit
that referenced
this pull request
Apr 3, 2023
…)"" This reverts commit aed5674.
netroy
added a commit
that referenced
this pull request
Apr 3, 2023
…)"" This reverts commit aed5674.
believe-Mahesh
pushed a commit
to believe-Mahesh/n8n
that referenced
this pull request
Apr 4, 2023
This reverts commit 33d9784.
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 4, 2023
* master: (87 commits) ci: Always run e2e tests on PR approval (no-changelog) (#5900) fix(core): Improve axios error handling in nodes (#5891) fix(HTTP Request Node): Detect mime-type from streaming responses (#5896) fix(Compare Datasets Node): Fuzzy compare not comparing keys missing in one of inputs fix(core): `augmentObject` should use existing property descriptors whenever possible (#5872) fix(core): Prevent augmentObject from creating infinitely deep proxies (#5893) feat(Postgres Node): Overhaul node fix: Add optional chaining for 'isArtificalRecoveredEventItem' (no-changelog) (#5860) fix(core): Use table-prefixes in queries in import commands (#5887) fix(AWS SNS Node): Fix an issue with messages failing to send if they contain certain characters (#5807) fix(core): Fix the issue of nodes not loading when run via npx (#5888) fix(Gmail Node): Gmail luxon object support, fix for timestamp test(editor): Fix failing licensing related e2e specs (no-changelog) (#5884) fix: Upgrade versions in pnpm-lock.yaml (no-changelog) Revert "fix(core): Improve axios error handling in nodes (#5699)" fix(editor): Update execution loading parameters after pushing test values (no-changelog) (#5876) ci: Fix catch clause lint rule (#5875) fix(editor): Fix loading executions in long execution list (#5843) fix(HTTP Request Node): Support for dot notation in JSON body feat(SSH Node): Hide the private key within the ssh credential (#5871) ... # Conflicts: # packages/nodes-base/credentials/Postgres.credentials.ts # packages/nodes-base/nodes/Postgres/Postgres.node.ts # packages/nodes-base/nodes/Postgres/test/v2/utils.test.ts # packages/nodes-base/nodes/Postgres/v2/PostgresV2.node.ts # packages/nodes-base/nodes/Postgres/v2/actions/common.descriptions.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/deleteTable.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/executeQuery.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/insert.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/select.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/update.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/upsert.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/versionDescription.ts # packages/nodes-base/nodes/Postgres/v2/helpers/interfaces.ts # packages/nodes-base/nodes/Postgres/v2/helpers/utils.ts # packages/nodes-base/nodes/Postgres/v2/methods/index.ts # packages/nodes-base/nodes/Postgres/v2/transport/index.ts
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 4, 2023
…rce-mapper-ui * feature/resource-mapping-component: (87 commits) ci: Always run e2e tests on PR approval (no-changelog) (#5900) fix(core): Improve axios error handling in nodes (#5891) fix(HTTP Request Node): Detect mime-type from streaming responses (#5896) fix(Compare Datasets Node): Fuzzy compare not comparing keys missing in one of inputs fix(core): `augmentObject` should use existing property descriptors whenever possible (#5872) fix(core): Prevent augmentObject from creating infinitely deep proxies (#5893) feat(Postgres Node): Overhaul node fix: Add optional chaining for 'isArtificalRecoveredEventItem' (no-changelog) (#5860) fix(core): Use table-prefixes in queries in import commands (#5887) fix(AWS SNS Node): Fix an issue with messages failing to send if they contain certain characters (#5807) fix(core): Fix the issue of nodes not loading when run via npx (#5888) fix(Gmail Node): Gmail luxon object support, fix for timestamp test(editor): Fix failing licensing related e2e specs (no-changelog) (#5884) fix: Upgrade versions in pnpm-lock.yaml (no-changelog) Revert "fix(core): Improve axios error handling in nodes (#5699)" fix(editor): Update execution loading parameters after pushing test values (no-changelog) (#5876) ci: Fix catch clause lint rule (#5875) fix(editor): Fix loading executions in long execution list (#5843) fix(HTTP Request Node): Support for dot notation in JSON body feat(SSH Node): Hide the private key within the ssh credential (#5871) ... # Conflicts: # packages/editor-ui/src/constants.ts # pnpm-lock.yaml
sunilrr
pushed a commit
to fl-g6/qp-n8n
that referenced
this pull request
Apr 24, 2023
* fix(core): Improve axios error handling in nodes * handle axios errors without a response (like when connection fails) --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
sunilrr
pushed a commit
to fl-g6/qp-n8n
that referenced
this pull request
Apr 24, 2023
This reverts commit 33d9784.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.