Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix calling error workflows in main mode recovery #5698

Merged

Conversation

flipswitchingmonkey
Copy link
Contributor

No description provided.

@flipswitchingmonkey flipswitchingmonkey marked this pull request as ready for review March 15, 2023 15:46
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: +0.23 🎉

Comparison is base (6242cac) 13.02% compared to head (693cc7f) 13.26%.

❗ Current head 693cc7f differs from pull request most recent head 33b2cad. Consider uploading reports for the commit 33b2cad to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5698      +/-   ##
==========================================
+ Coverage   13.02%   13.26%   +0.23%     
==========================================
  Files        2464     2465       +1     
  Lines      112831   112861      +30     
  Branches    17553    17554       +1     
==========================================
+ Hits        14695    14967     +272     
+ Misses      97636    97384     -252     
- Partials      500      510      +10     
Impacted Files Coverage Δ
.../cli/src/eventbus/MessageEventBus/recoverEvents.ts 13.33% <14.28%> (+0.47%) ⬆️
packages/cli/src/index.ts 100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@flipswitchingmonkey flipswitchingmonkey merged commit e0ea97a into master Mar 17, 2023
@flipswitchingmonkey flipswitchingmonkey deleted the pay-298-fix-triggering-of-error-workflows-in branch March 17, 2023 17:02
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 17, 2023
@janober
Copy link
Member

janober commented Mar 26, 2023

Got released with [email protected]

@janober
Copy link
Member

janober commented Mar 26, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
…5698)

* fix calling error workflows in main mode recovery

* cleanup

* remove WorkflowExecuteAdditionalData export from index

* revert refactor to fix test

* Update index.ts

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants